[PHP] On Random password

2008-08-16T16:49:25-07:00

Slight rework of Ted's code.

Main change is using mt_rand() instead of rand(), which is probably the cause of the speed issues which he mentioned.

<?php
	function randomPassword($length = 6){
		$chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_';
		$charsLen = strlen($chars)-1;
		$pass = '';
		
		for($n =0; $n < $length; $n++){
			$pass .= substr($chars, mt_rand(0, $charsLen), 1);
		}
		
		return $pass;
	}
?>

[PHP] On Cache any PHP function

2008-08-16T03:25:07-07:00

Disagree with comment #1: the conditional is checked regardless in your code, you have just added a redundant assignment.
Disagree with comment #2: Just makes the code more difficult to read with little gain.

Code changes:
- The "//$rebuild= false; // FORCE REBUILD SKIP for WINDOWS" line doesn't make any sense as adding it would just mean that the cache file is never created or updated.
- Removed need for the problematic @ operator which I personally believe causes more trouble than it's worth in the long run.
- Changed the two return statements into one so as not to have "Spaghetti Code".
- Reduced the chance of accidental conflict arising in the $cacheKey (although still far from perfect)
- Changed the $timeout from minutes to seconds to reduce code complexity and provide more flexibility.
- Added PHP tags to the code so that the syntax highlighter would work.

I still think this code is far from perfect though, especially with possible conflicts of the cache key. There is probably a much better way of creating it.

<?php
	function cache_function($buildCallback, array $args = array(), $timeoutSeconds = 3600){
		// Set up the filename for the cache file 
		if(is_array($buildCallback)){
			$cacheKey = get_class($buildCallback[0]) .'::'. $buildCallback[1];
		}else{
			$cacheKey = $buildCallback . ':' . implode(':', $args);
		}
		$cacheKey .= ':' . implode(':', $args);
		$file_path = CACHE_PATH . md5($cacheKey);
	
		// If the file hasn't yet been created or is out of date then call the require function and store it's result.
		if(!file_exists($file_path) OR filemtime($file_path) < (time() - $timeoutSeconds)){
			$result = call_user_func_array($buildCallback, $args);
			file_put_contents($file_path, serialize($result), LOCK_EX);
		// Else, grab the result from the cache.
		}else{
			$result = unserialize(file_get_contents($file_path));
		}
		
		return $result;
	}
?>

Gerry

[PHP] On Random password

[PHP] On Cache any PHP function