leighmac

[PHP] On ISBN10 to ISBN13

2007-10-03T01:55:07-07:00

Oh my goodness Mike you optimized my codes :) I like the loop unrolling implementation very much and the pre compute is brilliant great job!

[PHP] On Content Page Include

2007-10-01T20:58:06-07:00

I cannot get my php codes to highlight.. :( I must need need to include the opening and closing tags I will try again.

## php  [php]

<?php

  function content_include($page, $path = '') 
  {
    if (!file_exists($path.$page.'.php') or !preg_match('{^[a-z0-9-_]{1,32}$}', strtolower($page))) 
    {
      # Can't find the page or funky filename must not be allowable
      return false;
    }
    
    include $path.$page.'.php';
    
    return true;
  
   }
   
  
  if(!content_include($_GET['id'], 'pages/')) { include 'pages/no_page_error.php'; };


?>

[PHP] On ISBN10 to ISBN13

2007-10-01T07:00:29-07:00

I would write that function like this. I just changed a few things to make it easier to read and use for me and removed the error message out of the function making it more flexible IMO.

## Goes in your function lib [php]

function isbn10_to_13($isbn) 
 {
   if (!preg_match('{^[0-9]{10}$}', $isbn)) 
   { 
     # number is not 10 digits
     return false;
   } 
   
   # prefix 978 (bookland flag) to isbn and drop last digit (check digit)
   $isbn =  '978'.substr($isbn,0,9);
       
   $sum_of_digits = 0;
   $digit_postion = 0;
   
   # loop over each isbn digit
   foreach (str_split($isbn) as $digit)
   {
     # multiply each digit by its associated weighting factor (1 or 3)
     # and add them all together 
     $sum_of_digits += $digit * (($digit_postion % 2 == 0) ? 1 : 3);
     $digit_postion ++;
   }
   
   # divide the sum_of_digits by the modulus number (10) to find the remainder
   # and then minus 10 to get the check digit
   $check_digit = 10 - ($sum_of_digits % 10);
    
   # return isbn with check_digit
   return $isbn.$check_digit;    
  }   


## could use it like this in your template [php]

$converted_to_isbn13 = isbn10_to_13("0901690546");
 
 if($converted_to_isbn13) {
 
   echo $converted_to_isbn13;
 
 } else {
 
   echo 'Opps please check your digits!';
 
 }

[JavaScript] On Rating system for this site

2007-09-30T23:05:56-07:00

No worries :), The only things I could suggest to the next refactorer might be to break up the constructor a little bit more.. add a couple of constants for the strings and some sort of error handling.. if no one else posts I'll have a crack at that.

## Javascript [javascript]
// my codes did have an error. line 7 should read 
var rating = new Rating('rating_'+id, rating, {

[JavaScript] On Rating system for this site

2007-09-30T08:09:58-07:00

I like your ratings class it's easy to understand :). I'm not good enough at javascript to improve your class. But you might improve your view with something like this.

## Javascript [javascript]

var Rating = Class.create();
  // removed to make post more tidy
};

// Ratings helper for view
function rating_ui(id, rating, title) { 
  var rating = new Rating('rating_'+id, 0, {
    onClick: function(rating) {
      $('rating_'+id+'_spinner').show();
      $('rating_'+id+'_count').hide();
      this.disable();
      new Ajax.Request('/codes/'+title+'/refactors/'+id+';rate', {
        parameters: 'rating=' + rating,
        onComplete: function() {
          $('rating_'+id+'_spinner').hide();
          $('rating_'+id+'_count').show();
        }
      });
    }
  });  
}

## View [html_rails]

<div class="rating">
  <span id="rating_97"></span>
  <img alt="Spinner" class="spinner" id="rating_97_spinner" src="spinner.gif" style="display:none" />
  <span id="rating_97_count" class="count">
    No rating. You haven't rated it!
  </span>
</div>
<script type="text/javascript">
  rating_ui(97, 0, '16-extracting-style-from-a-css-file')
</script>