Eineki

[JavaScript] On how i make it work on Firefox?

2010-04-27T11:45:23-07:00

Is my previous post still pending approval?

[JavaScript] On pb resize image

2010-01-21T12:58:45-08:00

How is the function misbehaving?

[JavaScript] On pb resize image

2010-01-19T23:32:29-08:00

How call you the method?
Why do you use getElementById("apodimg") with the "" instead that
getElementById(apodimg)?
Have your image id="apodimg"?
I've tested the function with firebug on this page (redim_img(document.getElementsByTagName("img")[2])) and it worked well (after reverting the max size to 50px)

[JavaScript] On pb resize image

2010-01-19T20:58:39-08:00

The code is quite good to me.
Just some glitches to be corrected:
-- var apodimg = document.getElementById("apodimg");
you use an hardcoded string in place of the parameters you passed to the function, I think it was an oversight.
-- your calculations need to be rounded as width and height properties need integer values.
-- I introduced a test on the type of the input parameter in order to let you choice to pass
an element id or a DOM element.

function redim_img(apodimg)
{
   // you can pass a string with the id of the
   // image you want to resize or a reference 
   // to the image
   if (typeof(apodimg) == "string") {
    apodimg  = document.getElementById(apodimg);
   }

    var w=apodimg.width;
    var h=apodimg.height;

    if (w>=h && w>=200)	{
       h=Math.round(h*200/w);
       w=200;
    }
    if (h>w && h>=160) {
       w=Math.round(w*200/h);
       h=160;
    }

    apodimg.style.width=w+'px';
    apodimg.style.height=h+'px';
}

[JavaScript] On pb resize image

2010-01-19T20:57:39-08:00

function redim_img(apodimg)
{
   // you can pass a string with the id of the
   // image you want to resize or a reference 
   // to the image
   if (typeof(apodimg) == "string") {
    apodimg  = document.getElementById(apodimg);
   }

    var w=apodimg.width;
    var h=apodimg.height;

    if (w>=h && w>=200)	{
       h=Math.round(h*200/w);
       w=200;
    }
    if (h>w && h>=160) {
       w=Math.round(w*200/h);
       h=160;
    }

    apodimg.style.width=w+'px';
    apodimg.style.height=h+'px';
}

[PHP] On Need help decoding ZEND php file

2010-01-06T14:01:29-08:00

It is not a matter of nice/very nice/unpleasant peoples.

By the way, I want to be clear: I'm not pointing at you in any way,
just puntualizing...

Posting the code on this site, although encoded, you distribute
it and doing this you are breaking the license you have to agree
with before downloading the software.

I'm wondering if it is the case of modify the post in order to prevent
problems to the site owner.

You can have the source code simply by paying an adeguate
(for the seller at least) license fee as clearly stated into
the download page.

http://www.phpgrid.com/grid/license.php

[PHP] On array to csv

2009-12-07T19:42:33-08:00

I think there $arraydata is an array of hashes.
Here there is the code, assuming that the $arraydata fields names
don't contain the enclosure character.

reference: http://www.creativyst.com/Doc/Articles/CSV/CSV01.htm

<?php

function array_to_csv($arraydata, $delimeter=',', $linebreak="\n", $enclosure='"') {

  if (!is_array($arraydata)) {
    trigger_error('You must submit a valid array of csv data', E_USER_ERROR);
  }

  $innerSeparator = $enclosure.$enclosure;
  $fieldSeparator = $enclosure. $delimiter . $enclosure; //","
  $rowSeparator = $enclosure. $linebreak . $enclosure;   //"\n"
  $csv=array();

  // Format the header line
  $csv[] = join($fieldSeparator, array_keys($arraydata[0]));

  foreach ($arraydata as $row) {
    $foreach ($row as $k=>$v) {
       $row[$k]=str_replace($enclosure, $innerSeparator, $v);
    }
    $csv[] = join($fieldSeparator, $array_values($row));
  }

  return $enclosure . join($rowSeparator, $csv) . $enclosure;
}

[JavaScript] On Money formatting

2009-11-26T05:02:39-08:00

Just a divertissement.
It should be a good starting point, if not a solution.

If I had more confidence with the regular expressions ....
Maybe there is a chance to avoid the initial padding.

function format_money(n) {
   var str, padlen;
 
   str = parseFloat(n).toFixed(2).toString(),
   
   padlen = str.length % 3;
   if (0==padlen) padlen=3;

   return ("000".substr(padlen)+str).match(/(?:\d{3}\.\d{2}$)|(?:\d{3})/g)
        .join(',')
        .substr(3-padlen);
}


print(format_money(125.99))
print(format_money(1.99))
print(format_money(15000.99))
print(format_money(1500000.99))
print(format_money(15000000000000.99))

[C] On How to find max, min of three numbers?

2009-10-05T18:33:17-07:00

Hi Denis,
I'd to perform some other tests before posting, bolow you will find the correct version,
there is an additional test and swap in order to permit the "max" value to travel two
position down.

You know, maybe the algorithm is not the best one you can write since it count on swapping
only thre variables but I think, given the original limitation, is one of the more efficient.

Thanks for your annotations,
Eineki

int max = rand(); // or any init value
int min = rand(); // or any init value
int tmp = rand(); // or any init value


if (max < min) {
  min ^= max ^= min ^= max;
}

if (tmp < min) {
  min ^= tmp ^= min ^= tmp;
}


if (max < tmp) {
  max ^= tmp ^= max ^= tmp;
}

// now min , tmp and max are ordered

[PHP] On Generate table from array

2009-07-24T12:36:13-07:00

Just for exercise, I've rewritten the two loops. The function become.
I don't know if it is more efficient, you should try (I can't do it now).

<?
/**
 * Generates a multi-column table from an array 
 *
 * @param array		Array to process 
 * @param columns	Number of columns to return  
 * @param id		(Optional) ID attribute to attach to the table
 * @param class		(Optional) CSS class attribute to attach to the table 
 */
function generate_table($array, $columns, $table_id='', $table_class='') {
	$table = "<table";
	$table .= !empty($table_id) ? " id='$table_id'" : '';
	$table .= !empty($table_class) ? " class='$table_class'" : '';
	$table .= ">\n";
	
	while (count($array)) {
                $row=array_pad(array_splice($array,0,$columns),$columns,'&nbsp');
		$table .='<tr><td>'.join($row,'</td><td>')."</td></tr>\n";
        }
	$table .= "</table>\n";	
	return $table;
}
?>

[PHP] On Std PHP Output + Variable

2009-06-02T10:41:03-07:00

maybe you can use the comma (,) instead of dot (.) you save the unnecessary concatenation (somewhere I read it is somewhat quicker)

<?php

$name = "test";

echo 'Die ist ein : ' , $name;

?>

[PHP] On Retrieve username by user ID from two different tables.

2009-05-17T13:57:06-07:00

I'm not sure that the following code resolve your problems but I need more hints to better refactor your solution:
I found a lot of glitches in your code (I think it doesn't work) and I've tried to solve them but I was unable to do it.

on line 26 of your code you call am_getlatestscores with a NULL parameter (value you don't use in your query).
I suspect you have to pass to it a value (maybe a category?) but have no clues from where to get it.

You use numeric values to address the columns of the recordset you obtain from am_getlatestscores so I had
to guess the column names in order to obtain a query and retrieve your data.

In short, consider the refactoring just a hint to put you on the right track.

<?php
    function am_getlatestscores($db, $cat) {
        $sql = "SELECT username, score FROM `AMCMS_highscores` JOIN `AMCMS_users` ON `primkey`=`userkey` WHERE `primkey`='$cat' ORDER BY `score` DESC LIMIT 10;";
		$res = am_queries($db, $sql);
		return $res;
	}	

	function am_latesthighscores($db = NULL, $wholelinked = NULL, $list = NULL) {
		$numcats = am_numArcademGameCat($db, NULL);
		$res = am_getlatestscores($db, NULL);

		$scoreTemplate = '<a href="index.php?cat=%s">%s'
                       . ($wholelinked=='linkall'?'%s</a>':'</a>%s');
		
        if ($list == NULL) {
			$scoreTemplate = '<li>'.$coreTemplate.'</li>';
        }

		foreach ($res as $record) {
			if ($wholelinked!='none') {
               $numgamecat = ' ('.$record[0].')';
            }
            retvalue[]=($list == 'flat')? $record[1]: sprintf($scoreTemplate, $record[1], $record[1], $numgamecat);
	}

        if ($list == 'flat') {
		  return $retvalue;
	}

        if ($list == 'bracket') {
          echo '[ '. implode(' | ', $retvalue) . echo ' ]';
        } else {
		  echo implode('', $retvalue);     
	}
   }
?>

[Bash] On Unzip large database dump directly into mysql

2009-02-11T09:03:40-08:00

To me this solution is quite good, nothing to object :)

[Bash] On sort | uniq alternative

2009-02-08T02:06:04-08:00

Your problem is read. It is a standard utility (not a bash built in command) and calling it consume a lot of time (so your script get slow).

You should gain a lot of speed redirecting the standard input to awk with a single command: cat - (- stands for standard input).

Try it and let me know if it helped

#!/bin/bash
cat - | awk '!x[$0]++'

[C#] On Which is more readable? Math.* or if (...)

2009-01-03T09:13:15-08:00

The first refactoring is, to me, a little confusing, I had to look at it a second time to be sure that x mantain his value if lesser equal than y. Maybe you can use the ternary operator to compact the if into a single liner.

For the second refactoring, I prefer the version 2.2. It is terse as needed and more direct, clear and intuitive than the original version.

By the way, this is just my point of view.

###Snippet 1.3: if-block proposed refactoring
int x, y;
x = x > y? y : x;

[Bash] Multi language refactor

2008-12-25T08:59:13-08:00

Can you rewrite this oneliner into another language of your choice?

Thanks, Eineki

#!/bin/bash
echo -e "\n I wish you a merry Christmas and an happy new year! \n"
exit(0);

[PHP] On Login / Registration - be easier?

2008-12-13T15:57:36-08:00

I don't think you can simplify the function, it has to perform a lot of simple test.
We can just add a bit of syntax sugar using a case instead of the nested if and elseif in the register action.
For me it is a little more readable.
Maybe you should separate the view (that html part at the end of the code) from the controller part

<?php
ob_start();
include_once "include/config.php";

$login = safe_chars($login);
$pass = safe_chars($pass);

if($action == "register") {
  switch(true) {
    case ($login == ''):
         $error = "Nie podano loginu";
         break;
    case (!ereg("^[a-z0-9_\-]+$", $login)):
         $error = "Niepoprawny login";
         break;
    case (strlen($login) <= 2):
         $error = "Ten login jest za krÃ³tki";
         break;
    case (mysql_num_rows(mysql_query("SELECT `login` FROM `users` WHERE `login`='$login' LIMIT 1")) == 1):
         $error = "Ten login jest zajÄ™ty";
         break;
    case ($pass == ''):
         $error = "Nie podano hasÅ‚a";
         break;
    case ($repass == ''):
         $error = "Nie podano ponownie hasÅ‚a";
         break;
    case ($pass != $repass):
         $error = "Musisz wpisaÄ‡ identyczne hasÅ‚a";
         break;
    case ($mail == ''):
         $error = "Nie podano adresu e-mail";
         break;
    case (!eregi("^[a-zA-Z0-9_-]+(\.[a-zA-Z0-9_-]+)*@([a-zA-Z0-9_-]+)(\.[a-zA-Z0-9_-]+)*(\.[a-zA-Z]{2,4})$", $mail)):
         $error = "Musisz wpisaÄ‡ prawidÅ‚owy adres e-mail";
         break;
    default:
         mysql_query("INSERT INTO `users` SET `login`='$login', `pass`='".md5($pass)."', `mail`='$mail', `ip`='$ip', `reg_date`=NOW()");
}

else if($action == "login") {
   $query = sprintf("UPDATE `users` SET `ip`='%s', `last_login`=NOW() WHERE `login`='%s' AND `pass`='%s'", $ip, $login, md5($pass))
  if(mysql_affected_rows(mysql_query($query)) != 1) // assume there is a single pair login/pass into db
    $error = "Niepoprawne dane";
  else {
    $logged = 1;

} else if($action == "logout") {
  $logged = 0;
  header("Location: /");
}

else {
?>
<style type="text/css">
td {
	color: #808080;
	width: 150px;
}

span#error_msg {
	font-weight: bold;
	text-align: right;
	float: right;
	color: #ccc;
}
</style>

<form action="#" id="form" method="post" onsubmit="loginRegister(); return false;">
<input type="hidden" id="action" value="login" />
<p>Zaloguj siÄ™ lub
<a href="#" onclick="switchAction()">zarejestruj</a></p>
<br/>

<table>
<tr>
	<td>LOGIN</td>
	<td><input type="text" id="login" maxlength="15" /></td>
</tr>

<tr>
	<td>HASÅO</td>
	<td><input type="password" id="pass" /></td>
</tr>
</table>

<div id="register" style="display: none;">
<table>
<tr>
	<td>POWTÃ“RZ HASÅO</td>
	<td><input type="password" id="repass" /></td>
</tr>

<tr>
	<td>EMAIL</td>
	<td><input type="text" id="mail" maxlength="40" /></td>
</tr>
</table>
</div>

<p><span id="error_msg"></span><br/>
<br/><input type="submit" onclick="loginRegister(); return false;" value="OK" /></p>
</table>
</form>
<? }
if(isset($error)) print $error;
?>

[Java] On Factoring Integers

2008-11-26T23:24:45-08:00

The two functions, nextFactor and has nextFactor shared the common pattern I refactored into the findNextFactor() private method.
You have obfuscated the while conditions a bit but I'm sure you can see that the loop laying after the two sligthy different syntax are the same.

Once you get this, the two method get straight simple.
I added a runtime exception to cover the case of a call of nextFactor method without a previous check of hasNextFactor

I hope you can get through my english to the explanation :)

## Quick Fix [Java]

// line 44 while condition have to change to or you don't apply the last division 
//(but return the last factor everytime) => number don't become 1 => hasnextfactor misbehave.

while (factor <= number)

## Refactoring [Java]

public class factorGenerator
{
    private int number;
    private int factor;
    /**
     * Creates a FactorGenerator object used to determine the factor of an input value.
     * @param aNum is the input value
     **/
   public factorGenerator(int aNum)
   {
      number = aNum;
      factor = 2;
   }

   /**
    *  Find the next factor of a value.
    *  @return factor the next factor
    **/
   private int findNextFactor()
   {
   	while((factor < number) && ((number%factor)!=0)) factor++;
   	return factor;
   }
		
   /**
    * Apply the next factor of a value.
    * @return factor the next factor
    **/
   public int nextFactor() throws RuntimeException
   {
       int result = findNextFactor();
       if (result <= number) {
	   number/= result;
   	   return result;
       } else 
	   throw new RuntimeException(); 	   	  
       }

   /**
      Determine whether or not there are more factors.
      @return true there are more factors
   */
   public boolean hasMoreFactors()
   {
	return (findNextFactor()<=number);
   }
}

[C] On How to find max, min of three numbers?

2008-11-20T00:52:57-08:00

It is quite simple, once you know.
All the trick is based upon the XOR operator.
the table of truth of xor is:
T ^ T = F
F ^ F = F
T ^ F = T
F ^ T = T

I hope the explanation will be sufficient.
Try by yourself with a piece of paper and a pencil a couple of time and you will find the solution very easy.

/* Lets say we have two numbers: 27 and 145 (just two random values) into two separate variable */

int min = 27;  // 00011011 binary 8bit for 27  
int tmp = 145; // 10010001 

/* lets put the result into a third one */

int xored;
xored = min ^ tmp; // now contains 10001010

/* applying the table of xor you will find that starting
 * from xored you can obtain one of the value applying
 * the xor between xored itself and the other value. Let's try */

printf ("apply min (%d) to xored should obtain tmp (%d)\n", min, xored ^ min); // xored ^ min is 10010001
printf ("apply tmp (%d) to xored should obtain min (%d)\n", tmp, xored ^ tmp); // xored ^ tmp is 00011011

/* it is a well known property of xor used, for example, in 
 * computer security to share a secret between two or more actors
 * being sure that no guardian can reach the secret without the 
 * intervention of all the other ones */

/* now we can explode the totem: min ^= tmp ^= min ^= tmp
 * remember that you have to read the assignments right to left */

min = min ^ tmp;  // min becomes the xored signature;
tmp = min ^ tmp;  // xoring tmp versus the signature you obtain min original value and put it in tmp
min = min ^ tmp;  // min contains the signature, tmp contains the original value contained in min
                  // if you do the xor of the two values you obtain tmp original value.

[C] On How to find max, min of three numbers?

2008-11-18T23:55:08-08:00

Try this code, it was a kind of magic to me since I see it the first time in a programing class eons ago.

int max = rand(); // or any init value
int min = rand(); // or any init value
int tmp = rand(); // or any init value


if (tmp < min) {
  min ^= tmp ^= min ^= tmp;
}

if (max < tmp) {
  max ^= tmp ^= max ^= tmp;
}

// now min , tmp and max are ordered

[PHP] On remove http from url string

2008-11-11T10:49:54-08:00

Hi, you can use preg_replace function to do the job in a single line.

Reference for further investigations:
http://www.php.net/manual/it/function.preg-replace.php

<?
/*
E.g:
$s = 'http://google.com';
echo remove_http($s);
output: google.com
*/

   function remove_http($url='') 
   {
       return preg_replace("/^https?:\/\/(.+)$/i","\\1", $url);
   }

?>

[PHP] On Get Next Turn

2008-11-11T00:26:52-08:00

You are right, $next_seat had a wrong starting value. This version should work.

<?php
function get_next_seat($table_id, $start_seat) {
  $player_data=$this->admin->get_player_data($table_id);

  $maxint = intval(sprintf("%u",-1));
  $first_seat = $start_seat;
  $next_seat  = $maxint;

  foreach ($player_data["seats"] as $seat_id => $data) {
    if ($data["player_id"] !=0) {
      if ($seat_id < $first_seat) $first_seat = $seat_id;
      if (($seat_id > $start_seat) and ($seat_id < $next_seat)) $next_seat = $seat_id;
    }
  }

  return $next_seat < $maxint? $next_seat : $first_seat;
}
?>

[PHP] On Get Next Turn

2008-11-08T20:34:06-08:00

You are right, $next_seat had a wrong starting value. This version should work.

<?php
function get_next_seat($table_id, $start_seat) {
  $player_data=$this->admin->get_player_data($table_id);

  $first_seat = $start_seat;
  $next_seat  = intval(sprintf("%u",-1));

  foreach ($player_data["seats"] as $seat_id => $data) {
    if ($data["player_id"] !=0) {
      if ($seat_id < $first_seat) $first_seat = $seat_id;
      if (($seat_id > $start_seat) and ($seat_id < $next_seat)) $next_seat = $seat_id;
    }
  }

  return $start_seat < $next_seat? $next_seat : $first_seat;
}
?>

[PHP] On Array To Tablerows

2008-10-26T23:00:22-07:00

cool version the one liner one. missed the fifth star just for a mouse glitch

[PHP] On Array To Tablerows

2008-10-26T22:57:38-07:00

My previous version shortened is only 4 lines. I prefer the other one though

<?php
function array_to_tablerows($array = array(), $cols = 2) {
   if (!is_array($array) || $cols < 1) return false;
   for ($i=0, $tbl='', $len = count($array), $i<$len; $i+=$cols) 
         $tbl .= '<tr><td>'. implode('</td><td>',array_slice($array, $i, $cols)) . '</td></tr>';
   return ($len % $cols) ? substr($tbl,0,strlen($tbl)-5).'<td colspan="'.($cols-($len % $cols)).'">&nbsp</td></tr>' : $tbl;
}