Etandrib

[Ruby] On Three groups, three bits of information, too many partials.

2007-10-30T20:41:12-07:00

A problem with the solution Kevin presented is that the partial also includes the model name and if you are sharing the partials with other models then you'll need to dynamically swap out the model - in this case below it is member. I'm not sure how to do this. Any suggestions?

## views/shared/_email
<div class="phone">
<% fields_for "member[phone_attributes][]", phone do |p| %>
  <%= p.text_field :number, :index => nil %>
  <%= p.select :contact_type, Member::Contact_types, {}, :index => nil %>
<% end %>
</div>

[Ruby] On Three groups, three bits of information, too many partials.

2007-10-26T20:30:30-07:00

I also had to change the partial for adding a new model (location, email, etc.) you have to have a slash before shared or rails thinks that it is just the name of the partial. This is different than what the render => :partial syntax wants. I found this out by a proposed change in the Rails code. I'm also using Rails 2.0 Preview.

## ApplicationHelper

  def add_another(model_name, label = "Add another")
    link_to_function label do |page|
    	page.insert_html :bottom, model_name.pluralize, 
    	                 :partial => "/shared/#{model_name}", 
    	                 :object => model_name.camelize.constantize.new
    end
  end

[JavaScript] On ImageFlow - something like CoverFlow in Javascript

2007-10-26T20:15:02-07:00

I'm using safari v3 and it works just as it does in Camino. Performance isn't that great but hey it is CoverFlow in the browser. Pretty amazing JS. I don't have any ideas on refactoring.

[Ruby] Three groups, three bits of information, too many partials.

2007-10-25T13:42:58-07:00

I have three classes of people: Members, Volunteers, and Sponsors. They each can have multiple phones, emails, and locations. Right now I have a partial for each phone/email/location for each class. This doesn't seem very DRY since nothing changes except the model. How can this be refactored to share partials between these classes? Or is there an even better way I'm overlooking? Code followsâ€¦

## members/new.html.erb

  <%= f.text_field :first_name, :size => 15 %> 
  <%= f.text_field :last_name, :size => 15 %>

<div id="phones">Phone Numbers
  <%= render :partial => 'phone', :collection => @member.phones %>
</div>
  <%= add_another_link "phone" %><br><br>

<div id="emails">Email Addresses
  <%= render :partial => 'email', :collection => @ member.emails %>
</div>
<%= add_another_link 'email' %><br><br>

<div id="locations">Locations
  <%= render :partial => 'location', :collection => @ member.locations %>
</div>
  <%= add_another_link 'location' %><br><br>

## volunteers/new.html.erb

  <%= f.text_field :first_name, :size => 15 %> 
  <%= f.text_field :last_name, :size => 15 %>

<div id="phones">Phone Numbers
  <%= render :partial => 'phone', :collection => @ volunteer.phones %>
</div>
  <%= add_another_link "phone" %><br><br>

<div id="emails">Email Addresses
  <%= render :partial => 'email', :collection => @ volunteer.emails %>
</div>
<%= add_another_link 'email' %><br><br>

<div id="locations">Locations
  <%= render :partial => 'location', :collection => @ volunteer.locations %>
</div>
  <%= add_another_link 'location' %><br><br>

## sponsors/new.html.erb

  <%= f.text_field :first_name, :size => 15 %> 
  <%= f.text_field :last_name, :size => 15 %>

<div id="phones">Phone Numbers
  <%= render :partial => 'phone', :collection => @sponsor.phones %>
</div>
  <%= add_another_link "phone" %><br><br>

<div id="emails">Email Addresses
  <%= render :partial => 'email', :collection => @ sponsor.emails %>
</div>
<%= add_another_link 'email' %><br><br>

<div id="locations">Locations
  <%= render :partial => 'location', :collection => @ sponsor.locations %>
</div>
  <%= add_another_link 'location' %><br><br>

## _phone.html.erb
<div class="phone">
<% fields_for "member[phone_attributes][]", phone do |p| %>
  <%= p.text_field :number, :index => nil %>
  <%= p.select :contact_type, Member::Contact_types, {}, :index => nil %>
<% end %>
</div>

## _email.html.erb
<div class="email">
<% fields_for "member[email_attributes][]", email do |e| %>
  <%= e.text_field :address, :index => nil %>
  <%= e.select :contact_type, Member::Contact_types, {}, :index => nil %>
<% end %>
</div>

## _location.html.erb
<div class="location">
<% fields_for "member[location_attributes][]", location do |l| %>
  <%= l.text_field :address, :index => nil %>
  <%= l.select :contact_type, Member::Contact_types, {}, :index => nil %>
<% end %>
</div>

[JavaScript] On Combining javascript for 2+ models

2007-10-18T15:34:43-07:00

This works great. For other people following the call needs to look something similar to what I have below.

## _email.rhtml
<%= link_to_function "Remove", "mark_for_destroy(this,'.email')" %>

[JavaScript] Combining javascript for 2+ models

2007-10-17T21:32:28-07:00

This is some javascript which flags an element (and hides it from the current view) to be deleted when a form is submitted. Thanks for the help! I've learned a lot from my previous posts as well. This is a great community!

## application.js

function mark_for_destroy(element) {
  $(element).next('.should_destroy').value = 1;
  $(element).up('.phone').hide();
}

function e_mark_for_destroy(element) {
  $(element).next('.should_destroy').value = 1;
  $(element).up('.email').hide();
}

[Ruby] On Combining add/remove links

2007-10-17T21:06:19-07:00

Ah, ok. I see now. Thanks!

[Ruby] On Combining add/remove links

2007-10-17T20:50:56-07:00

Here is where I call the links. For some reason I get an error with the new code saying the following:
Showing app/views/people/_fields.rhtml where line #11 raised: "Add another" is not a valid constant name!"

##_fields

<h3>Phone Numbers</h3>
  <%= render :partial => 'phone', :collection => @person.phones %>
<%= add_associated_link "Add another" %>

[Ruby] On Combine contact attributes in model

2007-10-16T21:56:05-07:00

Thanks for this. I think I understand it a little better. I need to look into the class_eval stuff you've done here. I haven't seen that before.

[Ruby] Combining add/remove links

2007-10-16T21:41:57-07:00

I've got a bunch of add and remove functions that would be nice to refactor without all the duplication. Lets see what you can do! Thanks!

  ## Helper

  def add_phone_link(name)
    link_to_function "Add another" do |page|
    	page.insert_html :bottom, :phones, :partial => 'phone', :object => Phone.new
    end
  end
  
  def remove_phone_link(name)
    link_to_function "Remove" do |page|
      page["phone_#{params[:index]}"].remove
    end
  end
  
  def add_email_link(name)
    link_to_function "Add another" do |page|
    	page.insert_html :bottom, :emails, :partial => 'email', :object => Email.new
    end
  end
  
  def remove_email_link(name)
    link_to_function "Remove" do |page|
      page["email_#{params[:index]}"].remove
    end
  end

[Ruby] Combine contact attributes in model

2007-10-16T20:34:29-07:00

We have a model where a person has many phones, emails, addresses, etc. It would be nice to refactor these into something more compact. I'm basically replicating the "model_attributes" and "save_model" functions over and over for each piece of contact information I add to a user.

## Model
  def phone_attributes=(phone_attributes)
    phone_attributes.each do |attributes|
      if attributes[:id].blank?
        phones.build(attributes)
      else
        phone = phones.detect { |t| t.id == attributes[:id].to_i }
        phone.attributes = attributes
      end
    end
  end
  
  def save_phones
    phones.each do |t|
      if t.should_destroy?
        t.destroy
      else
        t.save(false)
      end
    end
  end
  
  def email_attributes=(email_attributes)
    email_attributes.each do |attributes|
      if attributes[:id].blank?
        emails.build(attributes)
      else
        email = emails.detect { |e| e.id == attributes[:id].to_i }
        email.attributes = attributes
      end
    end
  end
  
  def save_emails
    emails.each do |e|
      if e.should_destroy?
        e.destroy
      else
        e.save(false)
      end
    end
  end