[Ruby] On Making email addresses out of common names

2010-01-22T20:59:35-08:00

Not much to add, but you could shoten your one if quite nicely, since pop returns the element it's popping.

if name.length > 2
  name[1] = name[1] + name.pop
end

# or even:
name[1] = name[1] + name.pop if name.length > 2

[C#] Two methods, two enums.

2010-01-22T20:24:06-08:00

I have these two very similar methods. Both do the same thing, but one is based off the enum FIRSTSTATUS and the other is based off SECONDSTATUS. I'd like to cut this down to one method, but I'm not sure the best way.

private static bool SetFolderBasedOnFirstStatus(PurchaseOrder po)
{
    bool documentFinished = false;

    if (po.FirstStatus == FIRSTSTATUS.Complete)
    {
        po.Folder = DOCUMENTFOLDER.History;
        documentFinished = true;
    }
    else if (po.FirstStatus == FIRSTSTATUS.Partial)
        po.Folder = DOCUMENTFOLDER.InProgress;
    else
    {
        po.Folder = DOCUMENTFOLDER.Inbox;    
    }
    return documentFinished;
}

private static bool SetFolderBasedOnSecondStatus(PurchaseOrder po)
{
    bool documentFinished = false;

    if (po.SecondStatus == SECONDSTATUS.Complete)
    {
        po.Folder = DOCUMENTFOLDER.History;
        documentFinished = true;
    }
    else if (po.SecondStatus == SECONDSTATUS.Partial)
    {
        po.Folder = DOCUMENTFOLDER.InProgress;
    }

    return documentFinished;
}

mrgrande.livejournal.com

[Ruby] On Making email addresses out of common names

[C#] Two methods, two enums.