ReinH

[Ruby] On Hash assignment

2009-09-09T18:35:16-07:00

One option is to make a factory Hash. More a design alternative than a strict refactoring.

@subscriptions = Hash.new {|h,k| h[k] = SubscriptionType.make(k)}

[Ruby] On [Ruby] Iterating...

2009-09-09T18:11:52-07:00

I'm not sure that this can be significantly refactored. Ruby doesn't have a circular linked list class. #each is not equivalent in behavior. Here's the only thing I can see to refator:

def self.get_next
  @i += 1
  @i = 0 if @i >= CONT.length # fix bug where @i == CONT.length
  CONT[@i]
end

[Ruby] On Call a function to each member

2009-09-09T17:54:41-07:00

& is not a unary method. It's a sigil that instructs the interpreter to treat the following variable as a block, similar to the * sigil for array expansion.

[Ruby] On Button code creates a generic, styled input button.

2009-09-09T17:41:19-07:00

This code has issues in the HTML it generates (input tags are self-closing and do not have content, window.location= is an ugly hack), but nevertheless refactored for science. Assignment of onclick_event is buggy in original implementation (branches where the variable is undefined), has been fixed in refactor. Also used more intention revealing variable names.

def button(title, values)
  values[:type] ||= "button"
  values[:category] ||= "primary"

  onclick_event = values[:url] ? "window.location=#{values[:url]}" : values[:onclick]
  endcap = content_tag(:div, '&nbsp', :class => 'endcap')

  inline_icon = ""
  if values[:category]  =~ /secure|prev|next/
    inline_icon = content_tag(:img, '', :src => "../images/#{$&}.gif")
  end
      
  content_tag(:div, :class => "button button_" + values[:category]) do
    content_tag(:input, inline_icon + endcap,
      :value => title,
      :type => values[:type],
      :onclick => onclick_event,
      :class => values[:class],
      :id => values[:id]
    )
  end
end