zsysop.myopenid.com

[C#] On Need help drying up my controller

2011-09-23T22:05:30-07:00

I can pass data using parameters, but every Step within the wizard would need to have all of the fields of the previous step in the form in order to transfer all of the fields from the previous step(s). Would using params be a cleaner way to approach this?

The checks within the POSTs are there to handle multiple posts.

[C#] On Need help drying up my controller

2011-09-23T22:04:21-07:00

I can pass data using parameters, but every Step within the wizard would need to have all of the fields of the previous step in the form in order to transfer all of the fields from the previous step(s). Would using params be a cleaner way to approach this?

The checks within the POSTs are there to handle multiple posts.

[C#] On Need help drying up my controller

2011-09-23T22:04:17-07:00

I can pass data using parameters, but every Step within the wizard would need to have all of the fields of the previous step in the form in order to transfer all of the fields from the previous step(s). Would using params be a cleaner way to approach this?

The checks within the POSTs are there to handle multiple posts.

[C#] Need help drying up my controller

2011-09-22T11:34:36-07:00

Thanks for any help

   [Authorize(Roles="Administrator,DR")]
    public class RegistrarController : BaseController
    {
        private readonly IRegistrationService _registrationService;

        public const string WizardKey = "Wizard";
        public const string ActionKey = "Action";

        public RegistrarController(IRegistrationService registrationService)
        {
            this._registrationService = registrationService;
        }

      
        public ActionResult Dashboard()
        {
            var model = new RegistrarDashboardModel();
            var user = _membershipService.GetUser(this.User.Identity.Name);

            if (user == null)
            {
                ViewBag.ErrorMessage = "Error: Your username could not be found in our database.";
                return View("Error");
            }

            model.Name = user.UserName;
            model.Email = user.Email;
            model.RegistrarId = user.DeputyRegistrarId;

            if (!string.IsNullOrEmpty(user.DeputyRegistrarId))
            {
                var registrar = _registrationService.GetRegistrarBy(r => r.ID == user.DeputyRegistrarId).FirstOrDefault();
                if (registrar != null)
                {
                    model.Name = registrar.DR_NAME;
                    model.OrganizationId = registrar.ORG_NUM;
                    if (registrar.Organization != null)
                        model.OrganizationName = registrar.Organization.ORG_NAME;
    
                }
            }

            return View(model);
        }


        [HttpGet]
        public ActionResult Step1()
        {
            if (string.IsNullOrEmpty(this.RegistrarId))
            {
                ViewBag.ErrorMessage = "A valid registrar id is not associated with this account.";
                return View("Error");
            }

            NewRegistrantModel model;

            var wizard = TempData[WizardKey] as PersonRegistrationWizard;
            if (wizard == null || wizard.Step1Model == null)
            {
                wizard = new PersonRegistrationWizard();
                wizard.RegistrarId = this.RegistrarId;
                model = new NewRegistrantModel();
            }
            else
                model = wizard.Step1Model;

            wizard.CurrentStep = 1;
            wizard.Step1Model = model;

            TempData[WizardKey] = wizard;

            return View(model);
        }

        [HttpPost]
        public ActionResult Step1(NewRegistrantModel model) 
        {
            var wizard = TempData[WizardKey] as PersonRegistrationWizard;
            if (wizard == null)
                wizard = new PersonRegistrationWizard();

            if (!ModelState.IsValid)
                return View("Step1", model);

            var electionDate = _registrationService.GetUpcomingElectionFor(DateTime.Now);


            if (!electionDate.HasValue)
            {
                wizard.Step1Model = model;
                TempData[WizardKey] = wizard;
                ViewBag.ErrorMessage = "Sorry, no upcoming election was found within our database.";
                return View("Error");
            }

            if (!_registrationService.EligibleToVote(model.Birthdate.Value, electionDate.Value))
            {
                wizard.Step1Model = model;
                TempData[WizardKey] = wizard;
                ModelState.AddModelError("", string.Format("You must be 18 years of age or older by {0} election in order to register to Person.", electionDate.Value.ToShortDateString()));
                return View("Step1", model);
            }


            wizard.Step1Model = model;
            if (wizard.MaxCompletedStep < 1)
                wizard.MaxCompletedStep = 1;

            TempData[WizardKey] = wizard;

            return RedirectToAction("Step2");
        }


        [HttpGet]
        public ActionResult Step2()
        {
            PersonInformationModel model;

            var wizard = TempData[WizardKey] as PersonRegistrationWizard;
            if (wizard == null || wizard.MaxCompletedStep < 1)
                return RedirectToAction("Step1");

            wizard = MoveDataFromStep1ToStep2(wizard);

            if (wizard.Step2Model == null)
                model = new PersonInformationModel();
            else
                model = wizard.Step2Model;

            wizard.CurrentStep = 2;
            TempData[WizardKey] = wizard;

            return View(model);
        }


        [HttpPost]
        public ActionResult Step2(PersonInformationModel model) 
        {

            var wizard = TempData[WizardKey] as PersonRegistrationWizard;
            if (wizard == null || wizard.Step1Model == null || wizard.MaxCompletedStep < 1)
                return RedirectToAction("Step1");

            if (!ModelState.IsValid)
            {
                wizard.Step2Model = model;
                TempData[WizardKey] = wizard;
                return View("Step2", model);
            }

            model.Person.NotInStreetIndex = !StreetDataValid(model.Person);

            if (model.Person.NotInStreetIndex && !model.ConfirmCookResident)
            {
                wizard.Step2Model = model;
                TempData[WizardKey] = wizard;
                 ModelState.AddModelError("ConfirmCookResident", "The address entered was not found in our cook database. Please confirm that you a resident of Cook County Illinois in order to proceed");
                return View(model);
            }

            wizard.Step2Model = model;
            wizard = MoveDataFromStep1ToStep2(wizard);

            if (wizard.MaxCompletedStep < 2) 
                wizard.MaxCompletedStep = 2;
            
            TempData[WizardKey] = wizard;

            return RedirectToAction("Step3");
        }




        [HttpGet]
        public ActionResult Step3()
        {
            var wizard = TempData[WizardKey] as PersonRegistrationWizard;
            if (wizard == null || wizard.MaxCompletedStep < 2)
                return RedirectToAction("Step1");
            wizard.CurrentStep = 3;
            TempData[WizardKey] = wizard;

            return View(wizard);
        }


        [HttpPost]
        public ActionResult Step3(FormCollection form)
        {
            var wizard = TempData[WizardKey] as PersonRegistrationWizard;
            if (wizard == null ||  wizard.MaxCompletedStep < 2 || wizard.Step1Model == null || wizard.Step2Model == null)
                return RedirectToAction("Step1");

            if (!string.IsNullOrEmpty(form["editStep1"]))
                return RedirectToAction("Step1");
            else if (!string.IsNullOrEmpty(form["editStep2"]))
                return RedirectToAction("Step2");
            else
            {
                if (wizard.MaxCompletedStep < 2)
                {
                   // Display Error
                }
                if (ModelState.IsValid)
                {
                   
                    wizard = MoveDataFromStep1ToStep2(wizard);

                    var Person = BuildPersonFromModel(wizard);
                    var registration = new RegistrarPersonRegistration();

                    if (Person.Id > 0)
                    {
                        registration = _registrationService.GetManyRegistrarPersonRegistrationsBy(v => v.PersonId == Person.Id).FirstOrDefault();

                        if (registration == null || registration.Person == null)
                            throw new InvalidProgramException("The Person id supplied does not have a Person registration");

                        Person.LastUpdatedOn = DateTime.Now;
                        registration.Person.Copy(Person);
                        registration = _registrationService.UpdateRegistrarPersonRegistration(registration);

                    }
                    else
                    {

                        Person.CreatedBy = this.User.Identity.Name;
                        Person.CreatedOn = DateTime.Now;
                        Person.RegistrationTypeCode = "DEP";
                        Person.RegistrationStatusCode = "P";
                        Person.RegistrationDate = DateTime.Now;

                        registration = _registrationService.RegistrarRegisterPerson(wizard.RegistrarId, Person);
                            
                    }

                    _registrationService.Save();
                    wizard.Step2Model.Person.PersonId = registration.PersonId;
                    if (wizard.MaxCompletedStep < 3)
                        wizard.MaxCompletedStep = 3;

                    TempData[WizardKey] = wizard;
                }
                else
                {
                    return View(wizard);
                }
                return RedirectToAction("Step4");
            }

        }


        [HttpGet]
        public ActionResult Step4()
        {
            var wizard = TempData[WizardKey] as PersonRegistrationWizard;
            if (wizard == null || wizard.MaxCompletedStep < 3)
                return RedirectToAction("Step1");
            wizard.CurrentStep = 4;
            TempData[WizardKey] = wizard;

            return View(wizard);
        }


        [HttpPost]
        public ActionResult Step4(FormCollection form)
        {
            var wizard = TempData[WizardKey] as PersonRegistrationWizard;
            string action = form[ActionKey] == null ? string.Empty : form[ActionKey].ToString().ToUpper();

            if (wizard == null || wizard.MaxCompletedStep < 3 || 
            wizard.Step2Model == null || 
            wizard.Step2Model.Person == null || 
            !wizard.Step2Model.Person.PersonId.HasValue || 
            wizard.Step2Model.Person.PersonId.Value <= 0)
                return RedirectToAction("Step1");

            int PersonId = wizard.Step2Model.Person.PersonId.Value;
            var registration = new RegistrarPersonRegistration();

            switch (action)
            {
                case "PRINT":
                    registration = _registrationService.GetManyRegistrarPersonRegistrationsBy(rvr => rvr.PersonId == PersonId).FirstOrDefault();
                    if (registration == null)
                    {
                        ViewBag.ErrorMessage = "No Person id was provided.";
                        wizard = null;
                        return View("Error");
                    }

                     registration.Person.RegistrationStatusCode = "C";
                    _registrationService.UpdateRegistrarPersonRegistration(registration);
                    _registrationService.Save();
                    TempData[WizardKey] = null;

                    // TO DO: Return Generated PDF

                    break;
                case "ADD":
                    TempData[WizardKey] = null;
                    return RedirectToAction("Step1");
                case "DASHBOARD":
                    TempData[WizardKey] = null;
                    return RedirectToAction("Dashboard");
                default:
                    break;
            }

            return View(wizard);
        }


        private Person BuildPersonFromModel(PersonRegistrationWizard wizard)
        {
            int PersonId = 0;
            var modelPerson = wizard.Step2Model.Person;

            var Person = new Person();
            if (modelPerson.PersonId.HasValue)
            {
                Person = _registrationService.GetPersonBy(v => v.Id == modelPerson.PersonId.Value);
                if (Person == null)
                    throw new InvalidOperationException(string.Format("An invalid Person id was supplied {0}", Person.Id));
                PersonId = Person.Id;
            }

            Person = modelPerson.ToEntity();
            Person.Id = PersonId;

            return Person;
        }

        private PersonRegistrationWizard MoveDataFromStep1ToStep2(PersonRegistrationWizard wizard)
        {
            if (wizard == null || wizard.Step1Model == null)
                return null;
            if (wizard.Step2Model == null)
            {
                wizard.Step2Model = new PersonInformationModel();
            }

            wizard.Step2Model.Person.Identification = wizard.Step1Model.Identification;
            wizard.Step2Model.Person.Birthdate = wizard.Step1Model.Birthdate;
            wizard.Step2Model.Person.SocialSecurityNumber = wizard.Step1Model.SocialSecurityNumber;
            wizard.Step2Model.Person.IdSupplied = wizard.Step1Model.OtherIdProvided;
            return wizard;
        }

        private bool StreetDataValid(PersonData Person)
        {
            return _registrationService.ValidateStreet(Person.AddressNumber.Value, Person.AddressDirection, Person.AddressStreet, Person.AddressStreetType, Person.AddressPostDirection, Person.AddressCity, Person.AddressZip);

        }

[C#] Refactoring Suggestions

2011-08-01T12:20:18-07:00

Was looking for some suggestions for refactoring this

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using iTextSharp.text;
using iTextSharp.text.pdf;
using System.IO;
using Data.EntityFramework;

namespace Report
{
    public class ElectedOfficialListingReport
    {
        private readonly float Multiplier = 205;

        private readonly float FirstColumnLLX = 0;
        private readonly float FirstColumnURX = 205;

        private readonly float FirstColumnLLY = PageSize.LETTER.Height - 60;
        private readonly float FirstColumnURY = 10;

        private const float CellPaddingTop = 5f;
        private const float CellPaddingLeft = 15f;
        private const float TableSpacingAfter = 12f;

        private readonly int MaxColumns = 2; // 0 based 
        private int PageCount = 0;

        private float llx = 0;
        private float urx = 205;

        private int currentColumn = 0;
        private float pos;
        private int status = 0;

        private Font TitleFont;
        private Font MainHeaderFont;
        private Font SubHeaderFont;
        private Font DetailFont;
        private Font LabelFontBold;

        private readonly BaseColor PrimaryColor = new BaseColor(152, 184, 203);
        private readonly BaseColor SecondaryColor = new BaseColor(230, 237, 242);

        private readonly string fontPath = @"c:\\windows\\fonts\\MYRIADPRO-REGULAR.OTF";
        private readonly string boldFontPath = @"c:\\windows\\fonts\\MyriadPro-BlackCond.OTF";




        private readonly ElectionDataEntities _context = new ElectionDataEntities();

        public ElectedOfficialListingReport()
        {

            TitleFont = FontFactory.GetFont(boldFontPath, BaseFont.CP1252, BaseFont.EMBEDDED, 16);
            MainHeaderFont = FontFactory.GetFont(boldFontPath, BaseFont.CP1252, BaseFont.EMBEDDED, 12);
            SubHeaderFont = FontFactory.GetFont(fontPath, BaseFont.CP1252, BaseFont.EMBEDDED, 10);
            DetailFont = FontFactory.GetFont(fontPath, BaseFont.CP1252, BaseFont.EMBEDDED, 9);
            LabelFontBold = FontFactory.GetFont(boldFontPath, BaseFont.CP1252, BaseFont.EMBEDDED, 8);
        }


        public byte[] GenerateReport()
        {
            using (var stream = new MemoryStream())
            {
                Document document = new Document(PageSize.LETTER);
                try
                {

                    PdfWriter writer = PdfWriter.GetInstance(document, stream);
                    document.Open();

                    ColumnText dataColumns = new ColumnText(writer.DirectContent);
                    dataColumns = InitializeColumn(dataColumns, 0);

                    JurisdictionType previousJurisdictionType = null;
                    Jurisdiction previousJurisdiction = null;

                    

                    IList<PdfPTable> tables = new List<PdfPTable>();
                    bool includeOfficeNameInHeader = false;
                    bool useGroupedTemplate = false;

                    JurisdictionType jt;

                    var jurisdictions = (from jurisdictionType in _context.JurisdictionTypes
                                        join jurisdiction in _context.Jurisdictions on jurisdictionType.JurisdictionTypeId equals jurisdiction.JurisdictionTypeId
                                        orderby jurisdictionType.SortOrder, jurisdiction.SortOrder
                                        select jurisdiction)
                                        .ToList();

                    foreach (var jurisdiction in jurisdictions)
                    {
                        jt = _context.JurisdictionTypes.Where(jurisdictionType => jurisdictionType.JurisdictionTypeId == jurisdiction.JurisdictionTypeId).FirstOrDefault();

                        useGroupedTemplate = jt.JurisdictionLevel.ToUpper() == "LOCAL";

                        if (jt.JurisdictionLevel.ToUpper() == "FEDERAL" || jt.JurisdictionLevel.ToUpper() == "COUNTY" || jt.JurisdictionLevel.ToUpper() == "LOCAL" || jt.JurisdictionLevel.ToUpper() == "STATE")
                            includeOfficeNameInHeader = true;

                        // All Muni Wards  must be grouped together
                        if (previousJurisdiction != null && jurisdiction.JurisdictionTypeId.ToUpper() == "MUNIW" && 
                            jurisdiction.TaxCode.StartsWith("50-") && previousJurisdiction.JurisdictionCode.Substring(0, 4) == jurisdiction.JurisdictionCode.Substring(0, 4))
                            continue;

                        var officials = _context
                            .GetElectedOfficialsByTaxCode(jurisdiction.TaxCode)
                            .Select(o => new ElectedOfficialData { 
                                ElectedOfficialId = o.ElectedOfficialId,
                                FirstName = o.FirstName,
                                MiddleName = o.MiddleName,
                                LastName = o.LastName,
                                JurisdictionType = o.JurisdictionType,
                                JurisdictionName = o.JurisdictionName,
                                OfficeId = o.OfficeId,
                                OfficeName = o.OfficeName,
                                Appointed = o.Appointed,
                                ElectionDate = o.ElectionDate,
                                Term = o.Term,
                            })                                
                            .ToList();

                        officials = officials.Where(o => !o.OfficeName.ToUpper().Contains("COMMITTEE")).ToList();
                        ProcessOfficials(document, writer, ref dataColumns, ref previousJurisdictionType, ref previousJurisdiction, ref tables, jt, jurisdiction, useGroupedTemplate, includeOfficeNameInHeader, officials);
                    }



                    IList<JurisdictionType> jurisdictionTypes = _context.JurisdictionTypes.OrderBy(o => o.SortOrder).ToList();

                    foreach (var jurisdictionType in jurisdictionTypes)
                    {

                        var committeemen = _context.GetElectedOfficials()
                            .Where(eo => eo.JurisdictionType == jurisdictionType.ShortDescription && eo.OfficeName.ToUpper().Contains("COMMITTEE"))
                            .Select(o => new ElectedOfficialData
                            {
                                ElectedOfficialId = o.ElectedOfficialId,
                                FirstName = o.FirstName,
                                MiddleName = o.MiddleName,
                                LastName = o.LastName,
                                JurisdictionType = o.JurisdictionType,
                                JurisdictionName = o.JurisdictionName,
                                OfficeId = o.OfficeId,
                                OfficeName = o.OfficeName,
                                Appointed = o.Appointed,
                                ElectionDate = o.ElectionDate,
                                Term = o.Term,
                            })
                            .ToList();

                        if (committeemen != null & committeemen.Count() > 0)
                        {
                            
                            useGroupedTemplate = false;
                            includeOfficeNameInHeader = true;
                            JurisdictionType partyJT = new JurisdictionType
                            {
                                JurisdictionLevel = "Party",
                                JurisdictionTypeId = jurisdictionType.JurisdictionTypeId
                            };
                            ProcessOfficials(document, writer, ref dataColumns, ref previousJurisdictionType, ref previousJurisdiction, ref tables, partyJT, new Jurisdiction(), useGroupedTemplate, includeOfficeNameInHeader, committeemen);
                        }
                    }

                }
                finally
                {
                    document.Close();
                }

                return stream.ToArray();
            }
        }

        private void ProcessOfficials(Document document, 
            PdfWriter writer, 
            ref ColumnText dataColumns, 
            ref JurisdictionType previousJurisdictionType, 
            ref Jurisdiction previousJurisdiction, 
            ref IList<PdfPTable> tables, 
            JurisdictionType jurisdictionType, 
            Jurisdiction jurisdiction, 
            bool useGroupedTemplate, 
            bool includeOfficeNameInHeader, 
            List<ElectedOfficialData> officials)
        {

            bool specialWardJurisdiction = jurisdictionType.JurisdictionLevel.ToUpper() == "LOCAL" && jurisdiction.JurisdictionTypeId.ToUpper() == "MUNIW" && jurisdiction.TaxCode.StartsWith("50-");
            
            foreach (var official in officials)
            {
                if (jurisdictionType.JurisdictionLevel.ToUpper() == "LOCAL" && previousJurisdiction.JurisdictionCode == jurisdiction.JurisdictionCode)
                    continue;

                if (jurisdictionType.JurisdictionLevel.ToUpper() == "LOCAL" &&
                  jurisdiction.JurisdictionTypeId.ToUpper() == "MUNIW" &&
                  previousJurisdiction.JurisdictionCode.Substring(0, 4) == jurisdiction.JurisdictionCode.Substring(0, 4))
                    continue;


                if (previousJurisdictionType == null)
                {
                    dataColumns = PageHeader(dataColumns, jurisdictionType.JurisdictionLevel);
                    dataColumns.Go(false);
                    dataColumns = InitializeColumn(dataColumns, 0);
                }
                else if (previousJurisdictionType != null && previousJurisdictionType.JurisdictionTypeId != jurisdictionType.JurisdictionTypeId 
                    && !specialWardJurisdiction
                    && previousJurisdictionType.JurisdictionTypeId.ToUpper() != "MUNIW" ) 
                {
                    CreateNewPage(document, ref dataColumns);
                    dataColumns = PageHeader(dataColumns, jurisdictionType.JurisdictionLevel);
                    dataColumns.Go(false);
                    dataColumns = InitializeColumn(dataColumns, 0);
                }


                if (useGroupedTemplate)
                    tables = GenerateGroupedOfficeTemplate(document, writer, ref dataColumns, jurisdictionType, jurisdiction, specialWardJurisdiction);
                else
                    tables = GenerateOfficeTemplate(document, writer, ref dataColumns, official, jurisdictionType, true, includeOfficeNameInHeader);


                foreach (var table in tables)
                    AddMainContent(document, writer.DirectContent, ref dataColumns, table, jurisdictionType.JurisdictionLevel);

                previousJurisdiction = jurisdiction;
                previousJurisdictionType = jurisdictionType;
            }
        }



       
        private void AddMainContent(Document document, PdfContentByte pcb, ref ColumnText columns, PdfPTable table, string headerText, int numHeaderColumns = 0)
        {

            // Simulate adding table to column
            columns.AddElement(table);
            pos = columns.YLine;
            status = columns.Go(true);

            // if true than can add to current column
            if (!ColumnText.HasMoreText(status))
            {
                columns.AddElement(table);
                columns.YLine = pos;
                status = columns.Go(false);
            }
            else
            {
                currentColumn++;
                if (currentColumn <= MaxColumns) // Put content in a new column
                {
                    columns = CreateNewColumn(pcb, columns);
                    columns.AddElement(table);
                    status = columns.Go(false);
                }
                else // reset columns, create new page and add content to columns
                {
                    CreateNewPage(document, ref columns);
                    columns.SetText(null);

                    columns = PageHeader(columns, headerText);
                    columns.Go(false);

                    columns = InitializeColumn(columns, 0);
                    columns.AddElement(table);
                    status = columns.Go(false);
                }
            }
   

           
        }


        #region "Page, Column & Cell Methods"
        private ColumnText CreateNewPage(Document document, ref ColumnText columns)
        {
            PageCount++;
            document.NewPage();
            columns = InitializeColumn(columns, 0);
            return columns;
        }

        private ColumnText CreateNewColumn(PdfContentByte pcb, ColumnText columns)
        {
            status = 0;
            columns = new ColumnText(pcb);
            llx += Multiplier;
            urx += Multiplier;

            columns.SetSimpleColumn(llx, FirstColumnLLY, urx, FirstColumnURY);
            return columns;
        }

        private ColumnText InitializeColumn(ColumnText columns, int columnToInitialize)
        {
            currentColumn = columnToInitialize;
            llx = FirstColumnLLX + (Multiplier * columnToInitialize);
            urx = FirstColumnURX + (Multiplier * columnToInitialize);
            columns.SetSimpleColumn(llx, FirstColumnLLY, urx, FirstColumnURY);
            return columns;
        }


        private ColumnText InitializeFakeColumn(ColumnText columns)
        {
            float cLLX = FirstColumnLLX;
            float cURX = FirstColumnURX;
            columns.SetSimpleColumn(cLLX, FirstColumnLLY, cURX, FirstColumnURY);
            return columns;
        }

        private PdfPCell CreateNewCell()
        {
            PdfPCell cell = new PdfPCell();
            cell.Border = Rectangle.NO_BORDER;
            cell.PaddingLeft = CellPaddingLeft;
            return cell;
        }


        private void AddCell(IList<PdfPCell> cells, Phrase phrase, bool addBackgroundColor = false)
        {
            if (phrase == null)
                return;
            var cell = CreateNewCell();
            if (addBackgroundColor)
                cell.BackgroundColor = SecondaryColor;
            cell.AddElement(phrase);
            cells.Add(cell);
        }




        private void AddCell(IList<PdfPCell> cells, string data, Font font, bool capitilize, bool addBackgroundColor = false)
        {
            var cell = CreateNewCell();
            cell = AddDataToCell(cell, data, font, capitilize);

            if (cell != null)
            {
                if (addBackgroundColor)
                    cell.BackgroundColor = SecondaryColor;
                cells.Add(cell);
            }
        }


        private void AddCellPadTop(IList<PdfPCell> cells, string data, Font font, bool capitilize, bool addBackgroundColor = false)
        {
            var cell = CreateNewCell();
            cell = AddDataToCell(cell, data, font, capitilize);
            cell.PaddingTop = CellPaddingTop;

            if (addBackgroundColor)
                cell.BackgroundColor = SecondaryColor;

            if (cell != null)
                cells.Add(cell);
        }


        private void AddCellPadTop(IList<PdfPCell> cells, Phrase phrase, bool addBackgroundColor = false)
        {
            if (phrase == null)
                return;

            var cell = CreateNewCell();

            cell.PaddingTop = CellPaddingTop;

            if (addBackgroundColor)
                cell.BackgroundColor = SecondaryColor;

            cell.AddElement(phrase);
            cells.Add(cell);
        }


        private PdfPCell AddDataToCell(PdfPCell cell, string data, Font font, bool capitilize)
        {
            if (string.IsNullOrEmpty(data) || data.Trim() == string.Empty)
                return null;

            if (font == null)
                font = DetailFont;

            if (capitilize)
                data = data.ToUpper();

            if (cell == null)
                cell = CreateNewCell();
                
            Phrase phrase = new Phrase();
            phrase.Add(new Chunk(data, font));
            cell.AddElement(phrase);
            return cell;
        }

        private void AddLabelTextCell(IList<PdfPCell> cells, string label, string text, bool padTop, bool addBackgroundColor = false)
        {
            var cell = CreateNewCell();
            if (padTop)
                cell.PaddingTop = CellPaddingTop;

            var phrase = CreateLabelTextPhrase(label, text);
            if (phrase == null)
                return;

            cell.AddElement(phrase);

            if (addBackgroundColor)
                cell.BackgroundColor = SecondaryColor;

            cells.Add(cell);
        }

        private Phrase CreateLabelTextPhrase(string label, string text)
        {
            if (string.IsNullOrEmpty(text) || text.Trim() == string.Empty)
                return null;

            Phrase phrase = new Phrase();
            if (!string.IsNullOrEmpty(label) && label.Trim() != string.Empty)
                phrase.Add(new Chunk(label + " ", LabelFontBold));

            phrase.Add(new Chunk(text, DetailFont));

            return phrase;

        }

        #endregion


        private IList<PdfPTable> GenerateGroupedOfficeTemplate(Document document, PdfWriter writer, ref ColumnText columns, JurisdictionType jurisdictionType, Jurisdiction jurisdiction, bool specialWardJurisdiction = false)
        {
            IList<PdfPTable> tables = new List<PdfPTable>();
            IList<PdfPCell> headerCells = new List<PdfPCell>();
            IList<PdfPCell> detailCells = new List<PdfPCell>();
            PdfPTable tempTable = new PdfPTable(1);
            PdfPTable finalTable = new PdfPTable(1);

            var officials = new List<ElectedOfficialData>();

            if (!specialWardJurisdiction)
            {
                officials = _context.GetElectedOfficialsByTaxCode(jurisdiction.TaxCode)
                    .Select(o => new ElectedOfficialData
                    {
                        ElectedOfficialId = o.ElectedOfficialId,
                        FirstName = o.FirstName,
                        MiddleName = o.MiddleName,
                        LastName = o.LastName,
                        JurisdictionType = o.JurisdictionType,
                        JurisdictionName = o.JurisdictionName,
                        OfficeId = o.OfficeId,
                        OfficeName = o.OfficeName,
                        Appointed = o.Appointed,
                        ElectionDate = o.ElectionDate,
                        Term = o.Term,
                    }).Where(e => !e.OfficeName.ToUpper().Contains("COMMITTEE")).ToList();
            }
            else
            {
                officials = _context.GetElectedOfficials()
                    .Where(e => e.JurisdictionLevel.ToUpper() == "LOCAL" &&
                        e.JurisdictionType.ToUpper() == "MUNICIPAL WARDS" &&
                        e.JurisdictionCode.Substring(0, 4) == jurisdiction.JurisdictionCode.Substring(0, 4) &&
                        !e.OfficeName.ToUpper().Contains("COMMITTEE"))
                    .Select(o => new ElectedOfficialData
                    {
                        ElectedOfficialId = o.ElectedOfficialId,
                        FirstName = o.FirstName,
                        MiddleName = o.MiddleName,
                        LastName = o.LastName,
                        JurisdictionType = o.JurisdictionType,
                        JurisdictionName = o.JurisdictionName,
                        OfficeId = o.OfficeId,
                        OfficeName = o.OfficeName,
                        Appointed = o.Appointed,
                        ElectionDate = o.ElectionDate,
                        Term = o.Term,
                    }).ToList();
            }

            PdfPCell cell;
            Phrase phrase;
            bool addJurisdictionTypeHeader = true;
            int counter = 0;
            bool addBackgroundColor = false;
            int totalDetailCells = 0;
            

            foreach (var result in officials)
            {
                detailCells = new List<PdfPCell>();
                int wardSplitterIndex = 0;
                string jurisdictionHeader = string.Empty;

                wardSplitterIndex = result.JurisdictionName.IndexOf(",");

                if (addJurisdictionTypeHeader)
                {
                    //AddCell(headerCells, string.Format("{0}", result.JurisdictionType), MainHeaderFont, true);
                    if (!specialWardJurisdiction)
                        jurisdictionHeader = result.JurisdictionName;
                    else
                        jurisdictionHeader = result.JurisdictionName.Substring(0, wardSplitterIndex);

                    phrase = new Phrase(string.Format("{0}", jurisdictionHeader), SubHeaderFont);

                    cell = new PdfPCell(phrase);
                    cell.Border = Rectangle.NO_BORDER;
                    cell.BackgroundColor = PrimaryColor;
                    cell.PaddingLeft = CellPaddingLeft;
                    headerCells.Add(cell);

                    var addresses = (from oa in _context.OfficialAddresses
                                     join a in _context.Addresses
                                     on oa.AddressId equals a.AddressId
                                     where oa.ElectedOfficialId == result.ElectedOfficialId
                                     select new AddressData
                                     {
                                         AddressId = a.AddressId,
                                         Address = a.Address1,
                                         City = a.City,
                                         State = a.State,
                                         Zip = a.Zip,
                                         Phone = a.Phone,
                                         Fax = a.Fax,
                                         Email = a.Email,
                                         Web = a.URL,
                                         SortOrder = oa.SortOrder
                                     }).ToList();


                    bool includeAddressHeader = (addresses != null && addresses.Count() > 1);
                    foreach (var address in addresses)
                        GenerateAddressTemplate(headerCells, address, includeAddressHeader);


                    foreach(var item in headerCells)
                        tempTable.AddCell(item);
                    addJurisdictionTypeHeader = false;


                }


                addBackgroundColor = counter % 2 == 0;

                phrase = new Phrase(string.Format("{0} {1} {2}", result.FirstName, result.MiddleName, result.LastName).Replace("  ", " ").Trim(), DetailFont);
                if (specialWardJurisdiction == true)
                    result.OfficeName = string.Format("{0} {1}",result.OfficeName,
                        result.JurisdictionName.Substring(wardSplitterIndex + 1,
                        result.JurisdictionName.Length - wardSplitterIndex -1));

                phrase.Add(new Phrase(string.Format(" ({0})", result.OfficeName), DetailFont));

                AddCell(detailCells, phrase, addBackgroundColor);

                if (result.Appointed == false)
                {

                    phrase = new Phrase("ELECTED ", LabelFontBold);
                    phrase.Add(new Phrase(string.Format("{0:d}", result.ElectionDate), DetailFont));

                    //phrase.Add(new Phrase(" TERM ", LabelFontBold));
                    //phrase.Add(new Phrase(string.Format("{0}", result.Term), DetailFont));\


                    if (result.ElectionDate.HasValue)
                    {
                        phrase.Add(new Phrase(" NEXT ELECTION ", LabelFontBold));
                        phrase.Add(new Phrase(string.Format("{0}", string.Format("{0}", result.ElectionDate.Value.AddYears(result.Term).Year)), DetailFont));
                    }
                    AddCell(detailCells, phrase, addBackgroundColor);



                }
                else
                    AddCell(detailCells, "Appointed", LabelFontBold, true, addBackgroundColor);

                


                foreach (var item in detailCells)
                    tempTable.AddCell(item);

                if (CanFitInColumn(tempTable))
                {
                    finalTable = new PdfPTable(tempTable);
                }
                else
                {
                    if (finalTable.Rows.Count() > 0)
                        tables.Add(finalTable);
                    else
                        tables.Add(tempTable);

                    tempTable = new PdfPTable(1);
                    foreach(var item in headerCells)
                        tempTable.AddCell(item);
                    foreach(var item in detailCells)
                        tempTable.AddCell(item);
                }

                totalDetailCells += detailCells.Count();
                counter++;
            }

            int totalCells = 0;
            foreach (var t in tables)
                totalCells += t.Rows.Count();

            if (totalCells != (totalDetailCells + (headerCells.Count() * tables.Count())))
                tables.Add(finalTable);

            foreach (var t in tables)
                t.SpacingAfter = TableSpacingAfter;

            return tables;
            
            
        }

        private IList<PdfPTable> GenerateOfficeTemplate(Document document, PdfWriter writer, ref ColumnText columns, ElectedOfficialData result, JurisdictionType jurisdictionType, bool addOfficeHeader, bool includeOfficeNameInHeader)
        {
            IList<PdfPTable> tables = new List<PdfPTable>();
            IList<PdfPCell> cells = new List<PdfPCell>();

            PdfPCell cell;
            Phrase phrase;

            if (addOfficeHeader)
            {
                // for federal add title
                if (includeOfficeNameInHeader)
                    AddCell(cells, string.Format("{0}\n{1}", result.JurisdictionName, result.OfficeName), MainHeaderFont, true);
                else
                    AddCell(cells, string.Format("{0}", result.JurisdictionName), MainHeaderFont, true);
            }


            phrase = new Phrase(string.Format("{0} {1} {2}", result.FirstName, result.MiddleName, result.LastName).Replace("  ", " ").Trim(), SubHeaderFont);
            cell = new PdfPCell(phrase);
            cell.Border = Rectangle.NO_BORDER;
            cell.BackgroundColor = PrimaryColor;
            cell.PaddingLeft = CellPaddingLeft;
            cells.Add(cell);



            if (result.Appointed == false)
            {
                phrase = new Phrase("LAST ELECTED", LabelFontBold);
                phrase.Add(new Phrase(string.Format(" {0:d} ", result.ElectionDate), DetailFont));

                if (result.ElectionDate.HasValue)
                {
                    phrase.Add(new Phrase(" NEXT ELECTION ", LabelFontBold));
                    phrase.Add(new Phrase(string.Format("{0}", string.Format("{0}", result.ElectionDate.Value.AddYears(result.Term).Year)), DetailFont));
                }

                AddCellPadTop(cells, phrase);
            }
            else
                AddCellPadTop(cells, "Appointed", LabelFontBold, true);


            var addresses = (from oa in _context.OfficialAddresses
                             join a in _context.Addresses
                             on oa.AddressId equals a.AddressId
                             where oa.ElectedOfficialId == result.ElectedOfficialId
                             select new AddressData
                             {
                                 AddressId = a.AddressId,
                                 Address = a.Address1,
                                 City = a.City,
                                 State = a.State,
                                 Zip = a.Zip,
                                 Phone = a.Phone,
                                 Fax = a.Fax,
                                 Email = a.Email,
                                 Web = a.URL,
                                 SortOrder = oa.SortOrder
                             }).ToList();


            bool includeAddressHeader = (addresses != null && addresses.Count() > 1);
            foreach (var address in addresses)
                GenerateAddressTemplate(cells, address, includeAddressHeader);


            var table = new PdfPTable(1);
            foreach (var item in cells)
                table.AddCell(item);
            table.SpacingAfter = TableSpacingAfter;

            tables.Add(table);

            return tables;
        }


        private IList<PdfPCell> GenerateAddressTemplate(IList<PdfPCell> cells, AddressData addressData, bool generateHeader = false)
        {
            if (generateHeader == true)
            {
                Font font = new Font(DetailFont);
                font.SetStyle(Font.BOLD);
                if (addressData.SortOrder <= 1)
                    AddCellPadTop(cells, "Main Office", font, true);
                else if (addressData.SortOrder > 1)
                    AddCellPadTop(cells, "Secondary Office", font, true);
            }

            AddCell(cells, string.Format("{0}", addressData.Address), DetailFont, false);
            AddCell(cells, string.Format("{0}, {1} {2}", addressData.City, addressData.State, addressData.Zip), DetailFont, false);

            AddLabelTextCell(cells, "TEL   ", string.IsNullOrEmpty(addressData.Phone) || addressData.Phone.Trim() == "" ? string.Empty : string.Format("{0:(###) ###-####}", Convert.ToInt64(addressData.Phone)), false);
            AddLabelTextCell(cells, "FAX   ", string.IsNullOrEmpty(addressData.Fax)  || addressData.Fax.Trim() == "" ? string.Empty : string.Format("{0:(###) ###-####}",  Convert.ToInt64(addressData.Fax)) , false);
            AddLabelTextCell(cells, "WEB   ", addressData.Web, false);
            AddLabelTextCell(cells, "EMAIL ", addressData.Email, false);

            return cells;
        }





        private bool CanFitInColumn(PdfPTable table)
        {
            Document document = new Document(PageSize.LETTER);
            PdfWriter writer = PdfWriter.GetInstance(document, new MemoryStream());
            document.Open();
            ColumnText columnText = new ColumnText(writer.DirectContent);
            InitializeFakeColumn(columnText);
            columnText.AddElement(table);
            int tempStatus = columnText.Go(true);
            return !ColumnText.HasMoreText(tempStatus);
        }


        private ColumnText PageHeader(ColumnText columns, string headerText)
        {

            PdfPTable myTable = new PdfPTable(1);
            Rectangle rec = PageSize.LETTER;

            myTable.SetWidthPercentage(new float[] { PageSize.LETTER.Width }, rec);
 
            PdfPCell cell = new PdfPCell( new Phrase(headerText, TitleFont));
            cell.Colspan = 2;
            cell.Border= Rectangle.BOTTOM_BORDER;
            if (PageCount % 2 == 0)
            {
                cell.HorizontalAlignment = Element.ALIGN_RIGHT;
                cell.PaddingRight = CellPaddingLeft;
            }
            else
            {
                cell.HorizontalAlignment = Element.ALIGN_LEFT;
                cell.PaddingLeft = CellPaddingLeft;
            }


            myTable.AddCell(cell);

            columns.SetSimpleColumn(20, 90, PageSize.LETTER.Width - 16, PageSize.LETTER.Height - 20);
            columns.AddElement(myTable);
            columns.Go(false);

            return columns;
        }

    }
}

[C#] Need help with refactoring & optimizing

2011-05-20T07:49:48-07:00

Need some help optimizing & cleaning up the following two methods.
Thanks!

-- fixed up some of the errors within the code

    public class MyClass1
    {  
        private DataDestination1 _destination = new DataDestination1();
        private DataSource _source = new DataSource();

        public void ImportVoters()
        {
            LoggingEngine.Instance.Info(String.Format("{0} - Beginning Import", TaskName));
            var voters = _source.GetVoters(StartDate, EndDate);

            if (voters == null || !voters.Any())
            {
                LoggingEngine.Instance.Info(String.Format("{0} - No voter data found for dates between {1} and {2}", TaskName, StartDate, EndDate));
                return;
            }

            int totalImported = 0;
            int totalRecords = voters.Count();
            var options = new ParallelOptions { MaxDegreeOfParallelism = _maxParallel };

            var exceptions = new ConcurrentQueue<Exception>();
            var loopResult = Parallel.ForEach(voters, options, voter =>
            {
                try
                {
                    _destination.Push(voter);
                    var signature = _source.GetSignature(voter.CERTNUM);
                    if (signature != null)
                        _destination.Push(signature);
                    Interlocked.Increment(ref totalImported);
                }
                catch (Exception exception)
                {
                    exceptions.Enqueue(exception);
                    LoggingEngine.Instance.Error("Error Import ID" + voter.ID + " " + exception.Message);
                }

                if (totalImported % 1000 == 0)
                    LoggingEngine.Instance.Info(Thread.CurrentThread.ManagedThreadId + " - " + " Imported " + totalImported + " of " + totalRecords + " records ");
            });

            if (exceptions.Count() > 0) throw new ImportException(exceptions);

            LoggingEngine.Instance.Info("Import Competed: Imported " + totalImported + " of " + totalRecords + " records ");
        }

        private void ImportLogs()
        {
            LoggingEngine.Instance.Info(String.Format("{0} - Beginning log data import", TaskName));
            var logs = _source.GetVoterLogs(StartDate, EndDate);
            if (logs == null || !logs.Any())
            {
                LoggingEngine.Instance.Info(String.Format("{0} - No log data found for dates between {1} and {2}", TaskName, StartDate, EndDate));
                return;
            }

            int totalImported = 0;
            int totalRecords = logs.Count();
            var options = new ParallelOptions { MaxDegreeOfParallelism = _maxParallel };

            var exceptions = new ConcurrentQueue<Exception>();

            var loopResult = Parallel.ForEach(logs, options, log =>
            {
                try
                {
                    _destination.Push(log);
                    Interlocked.Increment(ref totalImported);
                }
                catch (Exception exception)
                {
                    exceptions.Enqueue(exception);
                    LoggingEngine.Instance.Error("Error Import ID" + log.ID+ " " + exception.Message);
                }

                if (totalImported % 1000 == 0)
                    LoggingEngine.Instance.Info(Thread.CurrentThread.ManagedThreadId + " - " + " Imported " + totalImported + " of " + totalRecords + " records ");
            });
            if (exceptions.Count() > 0) throw new ImportException(exceptions);

            LoggingEngine.Instance.Info("Import Complete: Imported " + totalImported + " of " + totalRecords + " records ");
        }
       
    }




    public class MyClass2
    {  
        private DataDestination2  _destination = new DataDestination2();
        private DataSource _source = new DataSource();

        public void ImportVoters()
        {
            LoggingEngine.Instance.Info(String.Format("{0} - Beginning Import", TaskName));
            var voters = _source.GetVoters(StartDate, EndDate);

            if (voters == null || !voters.Any())
            {
                LoggingEngine.Instance.Info(String.Format("{0} - No voter data found for dates between {1} and {2}", TaskName, StartDate, EndDate));
                return;
            }

            int totalImported = 0;
            int totalRecords = voters.Count();
            var options = new ParallelOptions { MaxDegreeOfParallelism = _maxParallel };

            var exceptions = new ConcurrentQueue<Exception>();
            var loopResult = Parallel.ForEach(voters, options, voter =>
            {
                try
                {
                    _destination.Push(voter);
                    var signature = _source.GetSignature(voter.CERTNUM);
                    if (signature != null)
                        _destination.Push(signature);
                    Interlocked.Increment(ref totalImported);
                }
                catch (Exception exception)
                {
                    exceptions.Enqueue(exception);
                    LoggingEngine.Instance.Error("Error Import ID" + voter.ID + " " + exception.Message);
                }

                if (totalImported % 1000 == 0)
                    LoggingEngine.Instance.Info(Thread.CurrentThread.ManagedThreadId + " - " + " Imported " + totalImported + " of " + totalRecords + " records ");
            });
            if (exceptions.Count() > 0) throw new ImportException(exceptions);
            LoggingEngine.Instance.Info("Import Competed: Imported " + totalImported + " of " + totalRecords + " records ");
        }

        private void ImportLogs()
        {
            LoggingEngine.Instance.Info(String.Format("{0} - Beginning log data import", TaskName));
            var logs = _source.GetVoterLogs(StartDate, EndDate);
            if (logs == null || !logs.Any())
            {
                LoggingEngine.Instance.Info(String.Format("{0} - No log data found for dates between {1} and {2}", TaskName, StartDate, EndDate));
                return;
            }

            int totalImported = 0;
            int totalRecords = logs.Count();
            var options = new ParallelOptions { MaxDegreeOfParallelism = _maxParallel };

            var exceptions = new ConcurrentQueue<Exception>();

            var loopResult = Parallel.ForEach(logs, options, log =>
            {
                try
                {
                    _destination.Push(log);
                    Interlocked.Increment(ref totalImported);
                }
                catch (Exception exception)
                {
                    exceptions.Enqueue(exception);
                    LoggingEngine.Instance.Error("Error Import ID" + log.ID+ " " + exception.Message);
                }

                if (totalImported % 1000 == 0)
                    LoggingEngine.Instance.Info(Thread.CurrentThread.ManagedThreadId + " - " + " Imported " + totalImported + " of " + totalRecords + " records ");
            });
            if (exceptions.Count() > 0) throw new ImportException(exceptions);
            LoggingEngine.Instance.Info("Import Complete: Imported " + totalImported + " of " + totalRecords + " records ");
        }

        private void ImportOtherData()
        {
            LoggingEngine.Instance.Info(String.Format("{0} - Beginning other data import", TaskName));
            var otherData = _source.GetOtherData(StartDate, EndDate);
            if (otherData == null || !otherData.Any())
            {
                LoggingEngine.Instance.Info(String.Format("{0} - No other data found for dates between {1} and {2}", TaskName, StartDate, EndDate));
                return;
            }

            int totalImported = 0;
            int totalRecords = logs.Count();
            var options = new ParallelOptions { MaxDegreeOfParallelism = _maxParallel };

            var exceptions = new ConcurrentQueue<Exception>();

            var loopResult = Parallel.ForEach(otherData, options, data=>
            {
                try
                {
                    _destination.Push(data);
                    Interlocked.Increment(ref totalImported);
                }
                catch (Exception exception)
                {
                    exceptions.Enqueue(exception);
                    LoggingEngine.Instance.Error("Error Import ID" + data.ID+ " " + exception.Message);
                }

                if (totalImported % 1000 == 0)
                    LoggingEngine.Instance.Info(Thread.CurrentThread.ManagedThreadId + " - " + " Imported " + totalImported + " of " + totalRecords + " records ");
            });
            if (exceptions.Count() > 0) throw new ImportException(exceptions);
            LoggingEngine.Instance.Info("Import Complete: Imported " + totalImported + " of " + totalRecords + " records ");
        }
       
    }

[Python] On isprime

2011-04-13T23:51:58-07:00

How about something like this?

def is_prime(number): 
	if number < 2: return False
	return all(number % i for i in xrange(2, number))

[C#] Cleaning up this method

2011-04-13T20:38:37-07:00

Is there any cleaner way to write this method

        private ReportData SetPartnerInfo(ReportData reportData, string partnerPrefix, Partner partner)
        {
            PropertyInfo propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "IDType");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.IdentificationType, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "ID");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.IdentificationId1, propertyInfo.PropertyType), null);


            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "FirstName");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.FirstName, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "MiddleName");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.MiddleName, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "LastName");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.LastName, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "LastNameOnBirthCertificate");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.LastNameOnBirthCert, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "Gender");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.Gender, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "ResidenceAddress");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.Address1Combined, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "City");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.City, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "County");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.County, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "State");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.State, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "DateOfBirth");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, partner.BirthDate, null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "Age");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.Age, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "Birthplace");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.BirthPlace, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "SSN");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.SSN, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "Occupation");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.Occupation, propertyInfo.PropertyType), null);

            // Set Parent Information
            var partnerParent = partner.Parents.Where(p => p.ParentType == PersonATypeCode).FirstOrDefault();

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "ParentAName");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partnerParent.FullName, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "ParentAAddress");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partnerParent.CityZipCombined, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "ParentABirthplace");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partnerParent.BirthPlace, propertyInfo.PropertyType), null);


            partnerParent = partner.Parents.Where(p => p.ParentType == PersonBTypeCode).FirstOrDefault();

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "ParentBName");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partnerParent.FullName, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "ParentBAddress");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partnerParent.CityZipCombined, propertyInfo.PropertyType), null);

            propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "ParentBBirthplace");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partnerParent.BirthPlace, propertyInfo.PropertyType), null);


            var partnerRaces = partner.PartnerRaces;
            if (partnerRaces != null && partnerRaces.Count() > 0)
            {
                string race = (partnerRaces.Count() == 1 ? partnerRaces.FirstOrDefault().RaceDescription : "OTHER");
                propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "Race");
                if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(race, propertyInfo.PropertyType), null);

            }

            if (propertyInfo != null) propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "OfHispanicOrigin");
            if (propertyInfo != null) propertyInfo.SetValue(reportData, partner.HispanicOrigin, null);


            if (!string.IsNullOrEmpty(partner.HispanicType))
            {
                var partnerOriginInfo = _cuContext.HispanicTypeLookups.Where(ht => ht.Code == partner.HispanicType).FirstOrDefault();
                if (partnerOriginInfo != null)
                {
                    propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "OfHispanicOriginInfo");
                    if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partnerOriginInfo.Description, propertyInfo.PropertyType), null);
                }

            }

            int partnerHighestGradeCompleted = 0;

            if (Int32.TryParse(partner.Education, out partnerHighestGradeCompleted))
            {
                if (partnerHighestGradeCompleted > 12)
                {
                    propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "EducationInfo");
                    if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType("12", propertyInfo.PropertyType), null);
                    propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "HigherEducationInfo");
                    if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.Education, propertyInfo.PropertyType), null);
                }
                else
                {
                    propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "EducationInfo");
                    if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType(partner.Education, propertyInfo.PropertyType), null);
                    propertyInfo = reportData.GetType().GetProperty(partnerPrefix + "HigherEducationInfo");
                    if (propertyInfo != null) propertyInfo.SetValue(reportData, Convert.ChangeType("00", propertyInfo.PropertyType), null);
                }
            }


            return reportData;

        }

[C#] Help me Refactor My Classes & Methods

2009-04-18T18:14:09-07:00

Please help me refactor this so that it is alot more simplified. I have numerous other model classes that do the same thing
Thanks in advance

UI Layer

        private void SaveEquipment()
        {
            int guid = new EquipmentService().SaveEquipment(GetEquipmentFromFormFields());
        }

        private Equipment GetEquipmentFromFormFields()
        {
            if (OriginalEquipment != null)
            {
                OriginalEquipment.Make = Make;
                OriginalEquipment.Description = Description;
                OriginalEquipment.EquipmentType = new CustomType(OwnershipId, OwnershipDescription);
                OriginalEquipment.Serial = Serial;
                OriginalEquipment.SvcNumber = SvcNumber;
                OriginalEquipment.OwnershipStatus = new CustomType(OwnershipId, OwnershipDescription);
                OriginalEquipment.PurchaseYear = PurchaseYear;
                OriginalEquipment.PurchaseRequestYear = PurchaseRequestYear;
                OriginalEquipment.CurrentLocation = new CustomType(CurrentLocationId, CurrentLocationName);
                OriginalEquipment.IsDHCP = IsDHCP;
                OriginalEquipment.Subnet = Subnet;
                OriginalEquipment.IPAddress = IPAddress;
                OriginalEquipment.Gateway = Gateway;
                OriginalEquipment.Mask = Mask;
                OriginalEquipment.DNSOne = DNSOne;
                OriginalEquipment.DNSTwo = DNSTwo;
                OriginalEquipment.Status = new CustomType(EquipmentStatusId, EquipmentStatusName);
            }
            else
            {
                OriginalEquipment = new Equipment(
                 EquipmentGuid
               , EquipmentName
               , Make
               , Description
               , new CustomType(TypeId, TypeDescription)
               , Serial
               , SvcNumber
               , new CustomType(OwnershipId, OwnershipDescription)
               , PurchaseYear
               , PurchaseRequestYear
               , new CustomType(CurrentLocationId, CurrentLocationName)
               , IsDHCP
               , Subnet
               , IPAddress
               , Gateway
               , Mask
               , DNSOne
               , DNSTwo
               , LastChangeDate
               , new CustomType(EquipmentStatusId, EquipmentStatusName)
                );
            }
            return OriginalEquipment;
        }

        private Equipment OriginalEquipment
        {
            get
            {
                if (Session["OriginalEquipment"] != null)
                    return Session["OriginalEquipment"] as Equipment;
                else
                    return null;
            }
            set { Session["OriginalEquipment"] = value; }
        }

// Model Layer

namespace Model
{
    public class Equipment
    {
        private int? _guid;
        private string _name;
        private string _make;
        private string _description;
        private CustomType _equipmentType;
        private string _serial;
        private string _svcNumber;
        private CustomType _ownershipStatus;
        private string _purchaseYear;
        private string _purchaseRequestYear;
        private CustomType _currentLocation;
        private int _isDHCP;
        private string _subnet;
        private string _ipAddress;
        private string _gateway;
        private string _mask;
        private string _dnsOne;
        private string _dnsTwo;
        private DateTime? _lastChangeDate;
        private CustomType _status;
        private Dictionary<string, string> _dirtyProperties = new Dictionary<string, string>();

        public Equipment() { }

        public Equipment(
                int? guid
                , string name
                , string make
                , string description
                , CustomType equipmentType
                , string serial
                , string svcNumber
                , CustomType ownershipStatus
                , string purchaseYear
                , string purchaseRequestYear
                , CustomType currentLocation
                , int isDHCP
                , string subnet
                , string ipAddress
                , string gateway
                , string mask
                , string dnsOne
                , string dnsTwo
                , DateTime? lastChangeDate
                , CustomType status
            )
        {
            Guid = guid;
            Name = name;
            Make = make;
            Description = description;
            EquipmentType = equipmentType;
            Serial = serial;
            SvcNumber = svcNumber;
            OwnershipStatus = ownershipStatus;
            PurchaseYear = purchaseYear;
            PurchaseRequestYear = purchaseRequestYear;
            CurrentLocation = currentLocation;
            IsDHCP = isDHCP;
            Subnet = subnet;
            IPAddress = ipAddress;
            Gateway = gateway;
            Mask = mask;
            DNSOne = dnsOne;
            DNSTwo = dnsTwo;
            Status = status;
        }

        public int? Guid
        {
            get { return _guid; }
            private set
            {
                if (value.HasValue)
                {
                    if (value <= 0)
                        throw new Exception("Invalid Guid");
                    if (_guid != null && _guid != value && !_dirtyProperties.ContainsKey("equipment_id"))
                        _dirtyProperties.Add("equipment_id", value.ToString());
                    _guid = value;
                }
            }
        }

        public string Name
        {
            get { return _name; }
            private set
            {
                if (string.IsNullOrEmpty(value))
                    throw new Exception("Invalid Equipment Name");
                if (_name != null && _name != value && !_dirtyProperties.ContainsKey("equipment_name"))
                    _dirtyProperties.Add("equipment_name", value);
                _name = value;
            }
        }

        public string Make
        {
            get { return _make; }
            set
            {
                if (_make != null && _make != value && !_dirtyProperties.ContainsKey("make_model"))
                    _dirtyProperties.Add("make_model", value);
                _make = value;
            }
        }

        public string Description
        {
            get { return _description; }
            set
            {
                if (_description != null && _description != value && !_dirtyProperties.ContainsKey("short_desc"))
                    _dirtyProperties.Add("short_desc", value);
                _description = value;
            }
        }

        public CustomType EquipmentType
        {
            get { return _equipmentType; }
            set
            {
                if (_equipmentType != null && _equipmentType != value && !_dirtyProperties.ContainsKey("equipment_type_id"))
                    _dirtyProperties.Add("equipment_type_id", value.Id);
                _equipmentType = value;
            }
        }

        public string Serial
        {
            get { return _serial; }
            set
            {
                if (_serial != null && _serial != value && !_dirtyProperties.ContainsKey("serial_number"))
                    _dirtyProperties.Add("serial_number", value);
                _serial = value;
            }
        }


        public string SvcNumber
        {
            get { return _svcNumber; }
            set
            {
                if (_svcNumber != null && _svcNumber != value && !_dirtyProperties.ContainsKey("service_number"))
                    _dirtyProperties.Add("service_number", value);
                _svcNumber = value;
            }
        }

        public CustomType OwnershipStatus
        {
            get { return _ownershipStatus; }
            set
            {
                if (_ownershipStatus != null && _ownershipStatus != value && !_dirtyProperties.ContainsKey("ownership_status"))
                    _dirtyProperties.Add("ownership_status", value.Id);
                _ownershipStatus = value;
            }
        }

        public string PurchaseYear
        {
            get { return _purchaseYear; }
            set
            {
                if (!string.IsNullOrEmpty(value))
                {
                    if (!Helper.IsStringNumeric(value) || value.Length != 4)
                        throw new Exception("Invalid Purchase Year");
                    if (_purchaseYear != null && _purchaseYear != value && !_dirtyProperties.ContainsKey("purchase_date"))
                        _dirtyProperties.Add("purchase_date", value);
                    _purchaseYear = value;
                }
            }
        }

        public string PurchaseRequestYear
        {
            get { return _purchaseRequestYear; }
            set
            {
                if (!string.IsNullOrEmpty(value))
                {
                    if (!Helper.IsStringNumeric(value) || value.Length != 4)
                        throw new Exception("Invalid Purchase Request Year");
                    if (_purchaseRequestYear != null && _purchaseRequestYear != value && !_dirtyProperties.ContainsKey("purchase_req_date"))
                        _dirtyProperties.Add("purchase_req_date", value);
                    _purchaseRequestYear = value;
                }
            }
        }

        public CustomType CurrentLocation
        {
            get { return _currentLocation; }
            set
            {
                if (_currentLocation != null && _currentLocation != value && !_dirtyProperties.ContainsKey("current_location_id"))
                    _dirtyProperties.Add("current_location_id", value.Id);
                _currentLocation = value;
            }
        }

        public int IsDHCP
        {
            get { return _isDHCP; }
            set
            {
                if (_isDHCP != null && _isDHCP != value && !_dirtyProperties.ContainsKey("dhcp"))
                    _dirtyProperties.Add("dhcp", value.ToString());
                _isDHCP = value;
            }
        }

        public string Subnet
        {
            get { return _subnet; }
            set
            {
                if (_subnet != null && _subnet != value && !_dirtyProperties.ContainsKey("subnet"))
                    _dirtyProperties.Add("subnet", value);
                _subnet = value;
            }
        }

        public string IPAddress
        {
            get { return _ipAddress; }
            set
            {
                if (_ipAddress != null && _ipAddress != value && !_dirtyProperties.ContainsKey("ipaddr"))
                    _dirtyProperties.Add("ipaddr", value);
                _ipAddress = value;
            }
        }

        public string Gateway
        {
            get { return _gateway; }
            set
            {
                if (_gateway != null && _gateway != value && !_dirtyProperties.ContainsKey("default_gateway"))
                    _dirtyProperties.Add("default_gateway", value);
                _gateway = value;
            }
        }
        public string Mask
        {
            get { return _mask; }
            set
            {
                if (_mask != null && _mask != value && !_dirtyProperties.ContainsKey("netmask"))
                    _dirtyProperties.Add("netmask", value);
                _mask = value;
            }
        }

        public string DNSOne
        {
            get { return _dnsOne; }
            set
            {
                if (_dnsOne != null && _dnsOne != value && !_dirtyProperties.ContainsKey("dns_1"))
                    _dirtyProperties.Add("dns_1", value);
                _dnsOne = value;
            }
        }


        public string DNSTwo
        {
            get { return _dnsTwo; }
            set
            {
                if (_dnsTwo != null && _dnsTwo != value && !_dirtyProperties.ContainsKey("dns_2"))
                    _dirtyProperties.Add("dns_2", value);
                _dnsTwo = value;
            }
        }

        public DateTime? LastChangeDate
        {
            get { return _lastChangeDate; }
            private set
            {
                if (value.HasValue)
                    _lastChangeDate = value;
            }
        }

        public CustomType Status
        {
            get { return _status; }
            set
            {
                if (_status != null && _status != value && !_dirtyProperties.ContainsKey("equipment_status_id"))
                    _dirtyProperties.Add("equipment_status_id", value.Id);
                _status = value;
            }
        }

        public Dictionary<string, string> DirtyProperties
        {
            get { return _dirtyProperties; }
            set { _dirtyProperties = value; }
        }
    }

    
    // CustomType Class
     public class CustomType
    {
        private string _id;
        private string _description;

        public CustomType() { }

        public CustomType(string id)
        {
            Id = id;
            Description = string.Empty;
        }

        public CustomType(string id, string description)
        {
            Id = id;
            Description = description;
        }

        public string Id 
        { 
            get { return _id; } 
            set { _id = value; } 
        }
        public string Description
        {
            get { return _description; }
            set { _description = value; }
        }
    }
}

       

namespace DAL
{
    public class EquipmentDB
    {
        public bool UpdateEquipment(Equipment entity)
        {
             if (entity.DirtyProperties.Count < 1)
                return false;
            bool updated;
            using (TransactionScope myScope = new TransactionScope(TransactionScopeOption.Required))
            {
                using (SqlConnection myConnection = new SqlConnection(AppConfiguration.ConnectionString))
                {
                    using (SqlCommand myCommand = new SqlCommand("ts_create_or_match_equipment_2", myConnection))
                    {
                        foreach (KeyValuePair<string, string> kvp in entity.DirtyProperties)
                        {

                            if (kvp.Key == "equipment_type_id"
                                || kvp.Key == "current_location_id"
                                || kvp.Key == "dhcp"
                                || kvp.Key == "equipment_status_id")
                                myCommand.Parameters.Add("@" + kvp.Key, SqlDbType.Int).Value = Int32.Parse(kvp.Value);
                            else if (kvp.Key == "LastChangeDate")
                                myCommand.Parameters.Add("@" + kvp.Key, SqlDbType.DateTime).Value = DateTime.Parse(kvp.Value);
                            else
                                myCommand.Parameters.AddWithValue("@" + kvp.Key, kvp.Value);
                        }
                        myCommand.CommandType = CommandType.StoredProcedure;
                        myConnection.Open();
                        myCommand.ExecuteNonQuery();
                        updated = true;
                    }
                    myConnection.Close();
                }
                myScope.Complete();
            }
            return true;
        }

        public int InsertEquipment(Equipment entity)
        {
            int id = 0;

            using (TransactionScope myScope = new TransactionScope(TransactionScopeOption.Required))
            {
                using (SqlConnection myConnection = new SqlConnection(AppConfiguration.ConnectionString))
                {
                    using (SqlCommand myCommand = new SqlCommand("ts_create_or_match_equipment_2", myConnection))
                    {
                        myCommand.Parameters.Add("@equipment_name", SqlDbType.VarChar, 64).Value = entity.Name;
                        myCommand.Parameters.Add("@make_model", SqlDbType.VarChar, 64).Value = entity.Make;
                        myCommand.Parameters.Add("@short_desc", SqlDbType.VarChar, 64).Value = entity.Description;
                        if (!string.IsNullOrEmpty(entity.EquipmentType.Id))
                            myCommand.Parameters.Add("@equipment_type_id", SqlDbType.Int).Value = Int32.Parse(entity.EquipmentType.Id);
                        myCommand.Parameters.Add("@serial_number", SqlDbType.VarChar, 64).Value = entity.Serial;
                        myCommand.Parameters.Add("@service_number", SqlDbType.VarChar, 64).Value = entity.SvcNumber;
                        myCommand.Parameters.Add("@ownership_status", SqlDbType.Char).Value = entity.OwnershipStatus.Id;
                        myCommand.Parameters.Add("@current_location_id", SqlDbType.Int).Value = Int32.Parse(entity.CurrentLocation.Id);
                        myCommand.Parameters.Add("@dhcp", SqlDbType.Int).Value = entity.IsDHCP;
                        myCommand.Parameters.Add("@subnet", SqlDbType.VarChar, 20).Value = entity.Subnet;
                        myCommand.Parameters.Add("@ipaddr", SqlDbType.VarChar, 20).Value = entity.IPAddress;
                        myCommand.Parameters.Add("@default_gateway", SqlDbType.VarChar, 20).Value = entity.Gateway;
                        myCommand.Parameters.Add("@netmask", SqlDbType.VarChar, 20).Value = entity.Mask;
                        myCommand.Parameters.Add("@dns_1", SqlDbType.VarChar, 20).Value = entity.DNSOne;
                        myCommand.Parameters.Add("@dns_2", SqlDbType.VarChar, 20).Value = entity.DNSTwo;
                        myCommand.Parameters.Add("@equipment_status_id", SqlDbType.Int).Value = Int32.Parse(entity.Status.Id);
                        myCommand.CommandType = CommandType.StoredProcedure;
                        myConnection.Open();
                        id = myCommand.ExecuteNonQuery();
                    }
                    myConnection.Close();
                }
                myScope.Complete();
            }
            return id;
        }

    }
}

[C#] On Refactoring Help Needed

2009-03-24T22:41:33-07:00

How does sp_InsertAddress and sp_UpdateAddress figure out that you are inserting/updating a current address as opposed to a former or mailing address? Is this based on the @address_street_type parameter containing "Current Address", "Former Address", or "Mailing Address" ? Or is @address_street_type actually suppose to contain "Avenue", "Street", "Road", "Place", "Lane", "Boulevard", etc?

-- I forgot to add a parameter for @address_type. This would be used to detect if it is a current/former/mailing address.

Can I assume that using the @gender at lines 442, 452, 654, 664 typos? Same for getAddressCity() being put into @address_state?

-- Yes sorry about that.

Can the interfaces IName, IAddress, and IPerson be changed or deleted? With your code above it doesn't look like they are actually used much.

-- Yes they can be changed.

Below is a quick refactoring, but there is still room for a lot more that can be done.

-- Thanks for your help!

[C#] Refactoring Help Needed

2009-03-24T00:41:50-07:00

Please help me make this code more maintainable.

Thanks in advance

public interface IName
{
    string getLastName();
    string getFirstName();
    string getMiddleName();
    string getSuffixName();
}

public class Name : IName
{
    private string _lastName;
    private string _firstName;
    private string _middleName;
    private string _suffixName;

    // Validation Methods
    // private set methods

    #region IName Members

    public string getLastName()
    {
        return _lastName;
    }

    public string getFirstName()
    {
        return _firstName;
    }

    public string getMiddleName()
    {
        return _middleName;
    }

    public string getSuffixName()
    {
        return _suffixName;
    }

    #endregion
}


public interface IAddress
{
    string getAddressNumber();
    string getAddressDirection();
    string getAddressStreet();
    string getAddressStreetType();
    string getAddressAptNum();
    string getAddressCity();
    string getAddressState();
    string getAddressZipcode();
    string getAddressCounty();
}

public class Address : IAddress
{
    private string _addressNumber;
    private string _addressDirection;
    private string _addressStreet;
    private string _addressStreetType;
    private string _addressAptNum;
    private string _addressrCity;
    private string _addressState;
    private string _addressZipcode;
    private string _addressCounty;

    // Validation Methods
    // private Set Methods
    // public get methods


    #region IAddress Members

    public string getAddressNumber()
    {
        return _addressNumber;
    }

    public string getAddressDirection()
    {
        return _addressDirection;
    }

    public string getAddressStreet()
    {
        return _addressStreet;
    }

    public string getAddressStreetType()
    {
        return _addressStreetType;
    }

    public string getAddressAptNum()
    {
        return _addressAptNum;
    }

    public string getAddressCity()
    {
        return _addressrCity;
    }

    public string getAddressState()
    {
        return _addressState;
    }

    public string getAddressZipcode()
    {
        return _addressZipcode;
    }

    public string getAddressCounty()
    {
        return _addressCounty;
    }

    #endregion
}
public interface IPerson
{
    int getId();
    IName getCurrentName();
    IName getFormerName();

    IAddress getCurrentAddress();
    IAddress getFormerAddress();
    IAddress getMailingAddress();

    DateTime getBirthdate();
    string getGender();
    string getSSNumber();
    string getPersonType();
    DateTime getRegistrationDate();
    string getIPAddress();
    string getBrowserInfo();

    string getHomePhone();
    string getWorkPhone();
    string getCellPhone();
    string getFaxNumber();
    string getEmailAddress();
    string getSecondaryEmailAddress();
    string getDriversLicense();

    bool save();
    void load();

}

public class Person : IPerson
{
    private int _id;
    private IName _currentName;
    private IName _formerName;

    private IAddress _currentAddress;
    private IAddress _formerAddress;
    private IAddress _mailingAddress;

    private DateTime _birthdate;
    private string _gender;
    private string _ssNumber;
    private string _personType;
    private DateTime _registrationDate;
    private string _ipAddress;
    private string _browserInfo;
    private string _driversLicense;

    private string _homePhone;
    private string _workPhone;
    private string _cellPhone;
    private string _faxNumber;
    private string _emailAddress;
    private string _secondaryEmailAddress;
    
    
    // private set methods

    #region IPerson Members

    public bool save()
    {
        DataLayer dl = new DataLayer();
        if (_id == 0)
            return dl.insertPerson(this);
        else
            return dl.updatePerson(this);
    }

    public void load()
    {
    }

    public int getId()
    {
        return _id;
    }

    public IName getCurrentName()
    {
        return _currentName;
    }

    public IName getFormerName()
    {
        return _formerName;
    }

    public IAddress getCurrentAddress()
    {
        return _currentAddress;
    }

    public IAddress getFormerAddress()
    {
        return _formerAddress;
    }

    public IAddress getMailingAddress()
    {
        return _mailingAddress;
    }

    public DateTime getBirthdate()
    {
        return _birthdate;
    }

    public string getGender()
    {
        return _gender;
    }

    public string getSSNumber()
    {
        return _ssNumber;
    }

    public string getPersonType()
    {
        return _personType;
    }

    public DateTime getRegistrationDate()
    {
        return _registrationDate;
    }

    public string getIPAddress()
    {
        return _ipAddress;
    }

    public string getBrowserInfo()
    {
        return _browserInfo;
    }

    public string getHomePhone()
    {
        return _homePhone;
    }

    public string getWorkPhone()
    {
        return _workPhone;
    }

    public string getCellPhone()
    {
        return _cellPhone;
    }

    public string getFaxNumber()
    {
        return _faxNumber;
    }

    public string getEmailAddress()
    {
        return _emailAddress;
    }

    public string getSecondaryEmailAddress()
    {
        return _secondaryEmailAddress;
    }

    public string getDriversLicense()
    {
        return _driversLicense;
    }

    #endregion
}

public class DataLayer
{

    public bool insertPerson(IPerson person)
    {
        bool inserted = false;
        SqlConnection cnDB = DatabaseConnection.GetOpenDBConnection();
        try
        {
            SqlCommand cmDB = new SqlCommand("sp_InsertName", cnDB);
            cmDB.CommandType = CommandType.StoredProcedure;
            cmDB.Parameters.Add("@last_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@last_name"].Value = person.getCurrentName().getLastName();
            cmDB.Parameters.Add("@first_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@first_name"].Value = person.getCurrentName().getFirstName();
            cmDB.Parameters.Add("@middle_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@middle_name"].Value = person.getCurrentName().getMiddleName();
            cmDB.Parameters.Add("@suffix_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@suffix_name"].Value = person.getCurrentName().getSuffixName();
            int id = cmDB.ExecuteNonQuery();

            cmDB = new SqlCommand("sp_InsertName", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@former_last_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@former_last_name"].Value = person.getFormerName().getLastName();
            cmDB.Parameters.Add("@former_first_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@former_first_name"].Value = person.getFormerName().getFirstName();
            cmDB.Parameters.Add("@former_middle_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@former_middle_name"].Value = person.getFormerName().getMiddleName();
            cmDB.Parameters.Add("@former_suffix_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@former_suffix_name"].Value = person.getFormerName().getSuffixName();
            cmDB.ExecuteNonQuery();

            // Insert Current Address

            cmDB = new SqlCommand("sp_InsertAddress", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_number"].Value = person.getCurrentAddress().getAddressNumber();
            cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_direction"].Value = person.getCurrentAddress().getAddressDirection();
            cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street"].Value = person.getCurrentAddress().getAddressStreet();
            cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street_type"].Value = person.getCurrentAddress().getAddressStreetType();
            cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_apt_number"].Value = person.getCurrentAddress().getAddressAptNum();
            cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_city"].Value = person.getCurrentAddress().getAddressCity();
            cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_state"].Value = person.getCurrentAddress().getAddressCity();
            cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_zipcode"].Value = person.getCurrentAddress().getAddressZipcode();
            cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_county"].Value = person.getCurrentAddress().getAddressCounty();
            cmDB.ExecuteNonQuery();

            // Insert Former Address

            cmDB = new SqlCommand("sp_InsertAddress", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_number"].Value = person.getFormerAddress().getAddressNumber();
            cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_direction"].Value = person.getFormerAddress().getAddressDirection();
            cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street"].Value = person.getFormerAddress().getAddressStreet();
            cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street_type"].Value = person.getFormerAddress().getAddressStreetType();
            cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_apt_number"].Value = person.getFormerAddress().getAddressAptNum();
            cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_city"].Value = person.getFormerAddress().getAddressCity();
            cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_state"].Value = person.getFormerAddress().getAddressCity();
            cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_zipcode"].Value = person.getFormerAddress().getAddressZipcode();
            cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_county"].Value = person.getFormerAddress().getAddressCounty();
            cmDB.ExecuteNonQuery();

            // Insert Mailing Address

            cmDB = new SqlCommand("sp_InsertAddress", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_number"].Value = person.getMailingAddress().getAddressNumber();
            cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_direction"].Value = person.getMailingAddress().getAddressDirection();
            cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street"].Value = person.getMailingAddress().getAddressStreet();
            cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street_type"].Value = person.getMailingAddress().getAddressStreetType();
            cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_apt_number"].Value = person.getMailingAddress().getAddressAptNum();
            cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_city"].Value = person.getMailingAddress().getAddressCity();
            cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_state"].Value = person.getMailingAddress().getAddressCity();
            cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_zipcode"].Value = person.getMailingAddress().getAddressZipcode();
            cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_county"].Value = person.getMailingAddress().getAddressCounty();
            cmDB.ExecuteNonQuery();

            // insert Personal Info

            cmDB = new SqlCommand("sp_InsertPersonalInfo", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@birthdate", System.Data.SqlDbType.DateTime);
            cmDB.Parameters["@birthdate"].Value = person.getBirthdate();
            cmDB.Parameters.Add("@gender", System.Data.SqlDbType.VarChar,1);
            cmDB.Parameters["@gender"].Value = person.getGender();
            cmDB.Parameters.Add("@ss_number", System.Data.SqlDbType.VarChar,20);
            cmDB.Parameters["@ss_number"].Value = person.getSSNumber();
            cmDB.Parameters.Add("@person_type", System.Data.SqlDbType.VarChar,20);
            cmDB.Parameters["@person_type"].Value = person.getPersonType();
            cmDB.Parameters.Add("@registration_date", System.Data.SqlDbType.DateTime);
            cmDB.Parameters["@registration_date"].Value = person.getRegistrationDate();
            cmDB.Parameters.Add("@ip_address", System.Data.SqlDbType.VarChar,20);
            cmDB.Parameters["@ip_address"].Value = person.getIPAddress();
            cmDB.Parameters.Add("@browser_info", System.Data.SqlDbType.VarChar,20);
            cmDB.Parameters["@browser_info"].Value = person.getBrowserInfo();
            cmDB.Parameters.Add("@drivers_license", System.Data.SqlDbType.VarChar,20);
            cmDB.Parameters["@drivers_license"].Value = person.getDriversLicense();
            cmDB.ExecuteNonQuery();

            //insert email address contact type
            cmDB = new SqlCommand("sp_InsertContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar,50);
            cmDB.Parameters["@contact_type"].Value = "Email";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@gender"].Value = person.getEmailAddress();
            cmDB.ExecuteNonQuery();

            //insert secondary email address contact type
            cmDB = new SqlCommand("sp_InsertContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Secondary Email";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@gender"].Value = person.getSecondaryEmailAddress();
            cmDB.ExecuteNonQuery();

            //insert home phone contact type
            cmDB = new SqlCommand("sp_InsertContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Home Phone";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact"].Value = person.getHomePhone();
            cmDB.ExecuteNonQuery();

            //insert work phone contact type
            cmDB = new SqlCommand("sp_InsertContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Work Phone";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact"].Value = person.getWorkPhone();
            cmDB.ExecuteNonQuery();

            //insert cell phone contact type
            cmDB = new SqlCommand("sp_InsertContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Cell Phone";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact"].Value = person.getCellPhone();
            cmDB.ExecuteNonQuery();

            //insert cell phone contact type
            cmDB = new SqlCommand("sp_InsertContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Fax Number";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact"].Value = person.getFaxNumber();
            cmDB.ExecuteNonQuery();


            inserted = true;
        }
        catch (SqlException sqlEx)
        {
            throw new Exception(GetSqlExceptionMessage(sqlEx.Number));
        }
        catch (Exception ex)
        {
            throw ex;
        }
        finally
        {
            if (cnDB.State == ConnectionState.Open)
                cnDB.Close();
        }
        return inserted;
    }

    public bool updatePerson(IPerson person)
    {
        bool inserted = false;
        SqlConnection cnDB = DatabaseConnection.GetOpenDBConnection();
        try
        {
            string id = person.getId();

            SqlCommand cmDB = new SqlCommand("sp_UpdateName", cnDB);
            cmDB.CommandType = CommandType.StoredProcedure;
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@last_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@last_name"].Value = person.getCurrentName().getLastName();
            cmDB.Parameters.Add("@first_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@first_name"].Value = person.getCurrentName().getFirstName();
            cmDB.Parameters.Add("@middle_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@middle_name"].Value = person.getCurrentName().getMiddleName();
            cmDB.Parameters.Add("@suffix_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@suffix_name"].Value = person.getCurrentName().getSuffixName();
            cmDB.ExecuteNonQuery();

            cmDB = new SqlCommand("sp_UpdateName", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@former_last_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@former_last_name"].Value = person.getFormerName().getLastName();
            cmDB.Parameters.Add("@former_first_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@former_first_name"].Value = person.getFormerName().getFirstName();
            cmDB.Parameters.Add("@former_middle_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@former_middle_name"].Value = person.getFormerName().getMiddleName();
            cmDB.Parameters.Add("@former_suffix_name", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@former_suffix_name"].Value = person.getFormerName().getSuffixName();
            cmDB.ExecuteNonQuery();

            // Update Current Address

            cmDB = new SqlCommand("sp_UpdateAddress", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_number"].Value = person.getCurrentAddress().getAddressNumber();
            cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_direction"].Value = person.getCurrentAddress().getAddressDirection();
            cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street"].Value = person.getCurrentAddress().getAddressStreet();
            cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street_type"].Value = person.getCurrentAddress().getAddressStreetType();
            cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_apt_number"].Value = person.getCurrentAddress().getAddressAptNum();
            cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_city"].Value = person.getCurrentAddress().getAddressCity();
            cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_state"].Value = person.getCurrentAddress().getAddressCity();
            cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_zipcode"].Value = person.getCurrentAddress().getAddressZipcode();
            cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_county"].Value = person.getCurrentAddress().getAddressCounty();
            cmDB.ExecuteNonQuery();

            // Update Former Address

            cmDB = new SqlCommand("sp_UpdateAddress", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_number"].Value = person.getFormerAddress().getAddressNumber();
            cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_direction"].Value = person.getFormerAddress().getAddressDirection();
            cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street"].Value = person.getFormerAddress().getAddressStreet();
            cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street_type"].Value = person.getFormerAddress().getAddressStreetType();
            cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_apt_number"].Value = person.getFormerAddress().getAddressAptNum();
            cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_city"].Value = person.getFormerAddress().getAddressCity();
            cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_state"].Value = person.getFormerAddress().getAddressCity();
            cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_zipcode"].Value = person.getFormerAddress().getAddressZipcode();
            cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_county"].Value = person.getFormerAddress().getAddressCounty();
            cmDB.ExecuteNonQuery();

            // Update Mailing Address

            cmDB = new SqlCommand("sp_UpdateAddress", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_number"].Value = person.getMailingAddress().getAddressNumber();
            cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_direction"].Value = person.getMailingAddress().getAddressDirection();
            cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street"].Value = person.getMailingAddress().getAddressStreet();
            cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_street_type"].Value = person.getMailingAddress().getAddressStreetType();
            cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_apt_number"].Value = person.getMailingAddress().getAddressAptNum();
            cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_city"].Value = person.getMailingAddress().getAddressCity();
            cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_state"].Value = person.getMailingAddress().getAddressCity();
            cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_zipcode"].Value = person.getMailingAddress().getAddressZipcode();
            cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@address_county"].Value = person.getMailingAddress().getAddressCounty();
            cmDB.ExecuteNonQuery();

            // Update Personal Info

            cmDB = new SqlCommand("sp_UpdatePersonalInfo", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@birthdate", System.Data.SqlDbType.DateTime);
            cmDB.Parameters["@birthdate"].Value = person.getBirthdate();
            cmDB.Parameters.Add("@gender", System.Data.SqlDbType.VarChar, 1);
            cmDB.Parameters["@gender"].Value = person.getGender();
            cmDB.Parameters.Add("@ss_number", System.Data.SqlDbType.VarChar, 20);
            cmDB.Parameters["@ss_number"].Value = person.getSSNumber();
            cmDB.Parameters.Add("@person_type", System.Data.SqlDbType.VarChar, 20);
            cmDB.Parameters["@person_type"].Value = person.getPersonType();
            cmDB.Parameters.Add("@registration_date", System.Data.SqlDbType.DateTime);
            cmDB.Parameters["@registration_date"].Value = person.getRegistrationDate();
            cmDB.Parameters.Add("@ip_address", System.Data.SqlDbType.VarChar, 20);
            cmDB.Parameters["@ip_address"].Value = person.getIPAddress();
            cmDB.Parameters.Add("@browser_info", System.Data.SqlDbType.VarChar, 20);
            cmDB.Parameters["@browser_info"].Value = person.getBrowserInfo();
            cmDB.Parameters.Add("@drivers_license", System.Data.SqlDbType.VarChar, 20);
            cmDB.Parameters["@drivers_license"].Value = person.getDriversLicense();
            cmDB.ExecuteNonQuery();

            //Update email address contact type
            cmDB = new SqlCommand("sp_UpdateContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Email";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@gender"].Value = person.getEmailAddress();
            cmDB.ExecuteNonQuery();

            //Update secondary email address contact type
            cmDB = new SqlCommand("sp_UpdateContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Secondary Email";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@gender"].Value = person.getSecondaryEmailAddress();
            cmDB.ExecuteNonQuery();

            //Update home phone contact type
            cmDB = new SqlCommand("sp_UpdateContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Home Phone";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact"].Value = person.getHomePhone();
            cmDB.ExecuteNonQuery();

            //Update work phone contact type
            cmDB = new SqlCommand("sp_UpdateContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Work Phone";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact"].Value = person.getWorkPhone();
            cmDB.ExecuteNonQuery();

            //Update cell phone contact type
            cmDB = new SqlCommand("sp_UpdateContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Cell Phone";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact"].Value = person.getCellPhone();
            cmDB.ExecuteNonQuery();

            //Update cell phone contact type
            cmDB = new SqlCommand("sp_UpdateContactType", cnDB);
            cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int);
            cmDB.Parameters["@person_id"].Value = id;
            cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact_type"].Value = "Fax Number";
            cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50);
            cmDB.Parameters["@contact"].Value = person.getFaxNumber();
            cmDB.ExecuteNonQuery();
            inserted = true;
        }
        catch (SqlException sqlEx)
        {
            throw new Exception(GetSqlExceptionMessage(sqlEx.Number));
        }
        catch (Exception ex)
        {
            throw ex;
        }
        finally
        {
            if (cnDB.State == ConnectionState.Open)
                cnDB.Close();
        }
        return inserted;

    }
}

[C#] Import File

2009-03-17T21:25:19-07:00

How would you refactor this?

    protected void btnUpload_Click(object sender, EventArgs e)
    {
        try
        {
            string strImportType = ddlImportType.SelectedValue.ToUpper();
            string strElection = ddlElection.SelectedValue.Trim();
            Stream fileStream = FileUpload1.FileContent;
            verifyUser();

            if (!isValidFile(FileUpload1.FileName.ToString().Trim())) return;

            DataSet dsImport = buildDataSet(fileStream, "Import", "\t");

            int rowsCount = dsImport.Tables[0].Rows.Count;
            int rowsImportedCount = 0;

            if (!isValidData(dsImport, strElection, strImportType)) return;

            switch (strImportType)
            {
                case "USERS":
                    rowsImportedCount = cDataLayer.importVoters(dsImport.Tables["Import"], strElection);
                    break;
                case "OFFICES":
                    rowsImportedCount = cDataLayer.importOffices(dsImport.Tables["Import"]);
                    break;
                case "GROUP OFFICES":
                    rowsImportedCount = cDataLayer.importGroupOffices(dsImport.Tables["Import"], strElection);
                    break;
            }
            jsMsgBox("Imported " + rowsCount + " of " + rowsImportedCount + " rows successfully!");
        }
        catch (Exception ex)
        {
            jsMsgBox(ex.Message);
        }
    }

    private Boolean isValidFile(string strFileName)
    {
        if (strFileName == string.Empty)
        {
            jsMsgBox("No File Selected.");
            return false;
        }
        return true;
    }

    private bool isValidData(DataSet dsImport, string strElection, string strImportType)
    {
        bool valid = true;
        int rowCount = dsImport.Tables[0].Rows.Count;
        int colCount = dsImport.Tables[0].Columns.Count;
        string errorFormat = "The import file is not in the correct format. Import cancelled.";
        string errorElection = "The import file does not contain the specified election. Import cancelled.";

        if (rowCount < 1) return false;

        switch (strImportType)
        {
  
            case "USERS":
                if (colCount != 19)
                {
                    jsMsgBox(errorFormat);
                    return false;
                }
                if (dsImport.Tables[0].Rows[1].ItemArray[2].ToString() != strElection)
                {
                    jsMsgBox(errorElection);
                    return false;
                }    
                break;
            case "OFFICES":
                if (colCount != 3)
                {
                    jsMsgBox(errorFormat);
                    return false;
                }
                break;
            case "GROUP OFFICES":
                if (colCount != 6)
                {
                    jsMsgBox(errorFormat);
                    return false;
                }
                if (dsImport.Tables[0].Rows[1].ItemArray[0].ToString() != strElection)
                {
                    jsMsgBox(errorElection);
                    return false;
                }
                break;
            default:
                jsMsgBox("Invalid Import Type Specified");
                valid = false;
                break;
        }
        return valid;
    }

    public DataSet buildDataSet(Stream fileStream, string tableName, string delimeter)
    {
        DataSet domains = new DataSet();
        domains.Tables.Add(tableName);
        try
        {
            StreamReader reader = new StreamReader(fileStream);
            string[] columns = reader.ReadLine().Split(delimeter.ToCharArray());
            foreach (string col in columns)
            {
                bool added = false;
                int i = 0;
                while (!(added))
                {
                    string columnName = col;
                    if (!(domains.Tables[tableName].Columns.Contains(columnName)))
                    {
                        domains.Tables[tableName].Columns.Add(columnName, typeof(string));
                        added = true;
                    }
                    else
                    {
                        i++;
                    }
                }
            }
            string strLine = string.Empty;
            do
            {
                strLine = reader.ReadLine();
                if (!string.IsNullOrEmpty(strLine))
                {
                    string[] items = strLine.Split(delimeter.ToCharArray());
                    domains.Tables[tableName].Rows.Add(items);
                }
            } while (strLine != null);
        }
        catch (Exception ex)
        {
            throw ex;
        }
        return domains;
    }