dive.myopenid.com

[Ruby] On shorten long variable names / beautify

2009-06-23T12:23:30-07:00

@Johannes, thx, but I think the cool thing about not breaking it up is that a grep or cmd+shift+f over the whole project is easier to read

@Martin, ok, there's some hints ... like eg see if I really have to pass current_user.id or to have the helper check what kindof object it got and then extract what it needs ...

more hints?

[Ruby] On Is there better way to write following lines of code

2009-06-22T19:13:45-07:00

Also put your attention to your quoting / SQL injection!

from http://api.rubyonrails.org/classes/ActiveRecord/Base.html

  class User < ActiveRecord::Base
    def self.authenticate_unsafely(user_name, password)
      find(:first, :conditions => "user_name = '#{user_name}' AND password = '#{password}'")
    end

    def self.authenticate_safely(user_name, password)
      find(:first, :conditions => [ "user_name = ? AND password = ?", user_name, password ])
    end

    def self.authenticate_safely_simply(user_name, password)
      find(:first, :conditions => { :user_name => user_name, :password => password })
    end
  end

[Ruby] On Decoding a json object while converting keys to symbols

2009-06-22T19:01:16-07:00

Adam is the man, once again :-)

[Ruby] On Iterating An Array - Need to target 6th item for no margin

2009-06-22T18:59:20-07:00

maybe have something like

= render first block 5 times, iterate from 0 to 5
= render last and special case

leaving you with 2 lines, instead of 6 or 1,
so that the two cases are easy to distinguish visually?

I just don't like too much logic in one line ...

[Ruby] shorten long variable names / beautify

2009-06-22T18:52:10-07:00

I wonder how you make a line like this more readable.

I mean it is quite readable, only it is a bit long, and lines like this break in the editor, so it's actually not very readable ... do you worry about things like this? how would you make this more beautiful?

(actually I already made a useless variable definition "nextmyvocabulary", just to shorten the redirect_to)

def upgrade_and_restart
  @myvocabulary.upgrade
  nextmyvocabulary = Myvocabulary.draw(current_user.id, params[:position], @myvocabulary.vocabulary.lesson.proficiency.id)
  redirect_to myvocabulary_url(nextmyvocabulary, :position => params[:position])
end

[Ruby] On While loop to get unique value

2009-01-22T14:13:00-08:00

nice nice nice thank you all! :-) uhm the magic 8 ... it's a variable to define the length of the vouchercode. but hm since it's always the 8 i coulda remove it ... good point!

[Ruby] While loop to get unique value

2009-01-06T16:44:48-08:00

Coming from python, I would say this is pretty straight forward. But knowing some ruby, I suspect there's a DRYer way, right?

def before_create_save(record)
  vouchercode = generate_vouchercode(8)
  while Voucher.find(:first, :conditions => {:vouchercode => vouchercode})
    vouchercode = generate_vouchercode(8)
  end
  record.vouchercode = vouchercode
end