Return the appropriate file handle


    <?php
function get_handle($type)
{
	if (type=="r")
	{
		if (isset($this->fhr)) return $this->fhr;
		else user_error("File not open for reading");
	}
	elseif (type=="w")
	{
		if (isset($this->fhw)) return $this->fhw;
		else user_error("File not open for writing");
	}
	elseif (type=="a")
	{
		if (isset($this->fha)) return $this->fha;
		else user_error("File not open for appending");
	}
	elseif (!isset($type))
	{
		if (isset($this->fhr)) return $this->fhr;
		elseif (isset($this->fhw)) return $this->fhw;
		elseif (isset($this->fha)) return $this->fha;
		else user_error ("File not open");
	}
	else user_error("Invalid type");
}
?>
    This method feels like it's way more complicated than it should be.

Update: added <?php to colourise.
    2010-02-09T00:35:08+00:00
    1171
    PHP
    return-the-appropriate-file-handle
    2
    Return the appropriate file handle
    
    2010-02-09T10:17:05+00:00
    1073
    
      1073
      http://macinnes.myopenid.com
      Nathan
      0.0
      4


    stuff.each do |name|
  name = name.downcase
  #size
  if name =~ /(double|twin)/
    size = 2
  elsif name =~ /(single)/
    size = 1
  else name =~ /[0-9]/
    size = name.match(/[0-9]{1,2}/)[0]
  end
  
  #type
  if name =~ /(male)/
    type = "Male Dorm"
  elsif name =~ /(female)/
    type = "Female Dorm"
  elsif name =~ /(double)/
    type = "Double Bed"
  elsif name =~ /(twin)/
    type = "Twin Bed"
  elsif name =~ /(single)/
    type = "Single Bed"
  else
    type = "Mixed Dorm"
  end
  
  if name =~ /(private)/
    priv = '1'
  else
    priv = '0'
  end

  if name =~ /(ensuite)/
    ensuite = '1'
  else
    ensuite = '0'
  end
  
  name = name.gsub(/(dorm|male|female|double|single|beds|bed|private|ensuite|twin|[\d\(\)*])/,'').squeeze(' ')
  
  puts "Name: #{name}, Size: #{size}, #{type}, #{priv}, #{ensuite}"
end
    any ideas on making this more concise?
    2009-09-10T13:15:41+00:00
    1030
    Ruby
    ungliness-and-long-too
    6
    ungliness and long too
    
    2009-09-11T09:16:17+00:00
    1697
    
      1697
      http://uberholden.myopenid.com
      uberholden.myopenid.com
      0.0
      0


      def show
    
    if params[:course_id] && permitted_to?(:browse, :videos)
      @course = Course.find(params[:course_id])
      @video = @course.videos.find(:first) 
      add_crumb("Watching #{@video.title}", course_video_path(@course, @video))
      
    elsif params[:course_id]
      @course = Course.find(params[:course_id])
      @video = @course.videos.find(params[:id])
      add_crumb("Watching #{@video.title}", course_video_path(@course, @video))
   
    elsif !permitted_to?(:browse, :videos)
      @video = Video.find(params[:id])
      add_crumb("Watching #{@video.title}", video_path(@video))
      
    end
    I thought of creating a before_filter to load the @course instance variable in to the show action - but it failed on the final elsif so I decided to manually add it in both conditions.
    2009-03-25T17:43:29+00:00
    802
    Ruby
    need-to-dry-this-if-else-up
    3
    Need to DRY this if-else up
    
    2009-03-27T04:37:55+00:00
    1343
    
      1343
      http://fnjord.myopenid.com
      fnjord.myopenid.com
      0.0
      1