F7f392b52ef3c0e342ff0ba90ae1ccd9

This is the homepage of my site codera, ideally each different section (seperated by the $_GET['f'] variable) should be on an include, or even better a different page so that I can link to the pysical pages and not have them all on one page, as is the case at the moment

<div id="main">
<?php

if($user == ""){
firehtml($_GET['f']);
}
else
{
//homepage functions for logged in users
if($_GET['f'] ==""){
$homepage = new homepage;
$homepage->clear();
$homepage->pulluser();
$homepage->buildhomepage();
$homepage->dumphomepage();
}
else if($_GET['f'] == "p")
{
//project functions

$projectserv = new sql_query;
$projectserv->projectserv();
$projectserv->projectdump();
$projects = $projectserv->projectarray;
$projectl = $projectserv->projectlink;

$i = 1;

echo "<div id=\"hplcontainer\">";
while($i <= sizeof($projects)){
	//$i--;
	if($projectl[$i] != ""){
	echo "<div id=\"homepagelist\">";
	echo "<a href =\"?f=e&e=" .$projectl[$i] . "\">" . $projects[$i] . "</a>";
	echo "</div>";
	
	$i++;
	}
	else
	{
	echo "<div id=\"homepagelist\">";
	echo $projects[$i];
	echo "</div>";	
	$i++;
	}
}
echo "</div>"; 	
}
else if($_GET['f'] == "np"){
$form = new project();
$form->projectform();	
}
} 
?>
</div>

Refactorings

No refactoring yet !

Bfec5f7d1a4aaafc5a2451be8c42d26a

macournoyer

October 22, 2007, October 22, 2007 17:44, permalink

No rating. Login to rate!

hey thelittleninja, I doubt someone would want to refactor all this. Think about submitting a much tinier piece of code, or only a part of the page you find particularly ugly.

D4aeba3e57cfa78a5dfd84a08849611e

Lokycss

October 27, 2007, October 27, 2007 20:32, permalink

No rating. Login to rate!

Sorry, my level english is very poor and so i'm not sure if understood the problem. Whatever you want is split the last source code on many files, and then, load in fuction of the parameter 'p' on the $_GET variable?

Your refactoring





Format Copy from initial code

or Cancel