Pastable version of How to break up this long but clean method

<pre class='prettyprint' language='cs'>protected override Dictionary&lt;GloballyFilteredPositionSource, DevicePosition&gt; Reconfigure (
			Dictionary&lt;GloballyFilteredPositionSource, DevicePosition&gt; positions)
		{
			/*
			 * with world unset, return current positions.
			 */
			if (World == null) {
				return positions;
			}

/*
			 * gather all valid volumes
			 */
			List&lt;Volume&gt; projectionVolumes = new List&lt;Volume&gt; ();

foreach (Room r in World.GetRooms ()) {
				if (&quot;1&quot;.Equals (r.GetAttribute (WantDeviceConstant))) {
					projectionVolumes.Add (r.Volume);
				}
			}

/*
			 * create precomputed distance info
			 */
			var compositions =
				/*
				 * for each combination...
				 */
				from src in positions
				from target in projectionVolumes

/*
				 * remove invalid positions
				 */
				where src.Value != null

/*
				 * create bunch of info
				 */
				select new {
					Pair = src,
					Target = target,
					Dist = target.Dist (src.Value.Position),
				};

/*
			 * apply filter
			 */
			compositions = compositions.Where (x =&gt; x.Dist &lt; MaxDist);

/*
			 * presort
			 */
			compositions = compositions.OrderBy (x =&gt; x.Dist);

/*
			 * store result
			 */
			compositions = compositions.ToList ();

/*
			 * find and store best matches
			 */
			Dictionary&lt;GloballyFilteredPositionSource, DevicePosition&gt; resultingMatches
				= new Dictionary&lt;GloballyFilteredPositionSource, DevicePosition&gt; (positions);

while (compositions.Any ()) {
				/*
				 * find best assignment
				 */
				var bestMatch = compositions.First ();

/*
				 * remove used sources and destinations
				 */
				compositions = compositions.Where (x =&gt; x.Pair.Key != bestMatch.Pair.Key);
				compositions = compositions.Where (x =&gt; x.Target != bestMatch.Target);
				compositions = compositions.ToList (); // tested: improves performance

/*
				 * ultimately add current pair to results
				 */
				DevicePosition dpResult = new DevicePosition (
					bestMatch.Target.Center,
					bestMatch.Pair.Value.Time);
				resultingMatches[bestMatch.Pair.Key] = dpResult;
			}

return resultingMatches;
		}</pre>
<a href="http://www.refactormycode.com/codes/944-how-to-break-up-this-long-but-clean-method" style="color:#fff" title="As seen on RefactorMyCode.com"><img alt="Small_logo" src="http://www.refactormycode.com/images/small_logo.gif" style="border:0" /></a>

Refactor :my => 'code'

Recent

Popular

Pastable version of How to break up this long but clean method