B04a553de1b8b45433b841bba440cc42

Hi guys, how can be simplified this? Also not sure whether this code is fast enough... 

def render_page_hierarchy(roots)
    html = ""
    roots.each do |item|
      row = td(link_to(item.title, edit_admin_page_url(item.id), :style => "padding-left:#{item.level*10}px"))
      row << td(item.created_at)
      row << td(item.human_type_name )
      row << td(pages_links(item) )
      html << content_tag(:tr, row)
      html << render_page_hierarchy(item.children)
    end
    return html
  end

Refactorings

No refactoring yet !

880cbab435f00197613c9cc2065b4f5a

danielharan

May 1, 2009, May 01, 2009 15:12, permalink

No rating. Login to rate!

I wrote a semantic-menu plugin for menus; is this what you're rendering here? Seems you're mixing 3 different concerns :O
http://github.com/danielharan/semantic-menu/tree/master

Your refactoring





Format Copy from initial code

or Cancel