Pastable version of Refactor, fix and optimize the character replacement function

<pre class='prettyprint' language='java'>package engine;

import junit.framework.Assert;
import junit.framework.TestCase;

public class StringFunctionsTest extends TestCase {
		
	public void testEscapeXMLSimple(){
		final String simple = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&lt;![CDATA[&lt;sender&gt;John &amp; Smith&lt;/sender&gt;]]&gt;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;		
		final String expected = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&amp;#60;sender&amp;#62;John &amp;#38; Smith&amp;#60;/sender&amp;#62;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;
		String result = StringFunctions.escapeXML(simple);
		Assert.assertTrue(result.equals(expected));
	}
	
	public void testEscapeXMLCDATAInsideCDATA(){
		final String stringWithCDATAInsideCDATA = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&lt;![CDATA[&lt;sender&gt;John &lt;![CDATA[Inner &amp; CD ]]&gt;&amp; Smith&lt;/sender&gt;]]&gt;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;		
		final String expected = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&amp;#60;sender&amp;#62;John &amp;#60;![CDATA[Inner &amp;#38; CD &amp; Smith&lt;/sender&gt;]]&gt;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;
		String result = StringFunctions.escapeXML(stringWithCDATAInsideCDATA);		
		Assert.assertTrue(result.equals(expected));
	}
	
	public void testEscapeXMLCDATAWithoutClosingTag(){		
		final String stringWithCDATAWithoutClosingTag = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&lt;![CDATA[&lt;sender&gt;John &amp; Smith&lt;/sender&gt;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;
		try{
			String result = StringFunctions.escapeXML(stringWithCDATAWithoutClosingTag);
		}catch(StringIndexOutOfBoundsException exception){
			Assert.assertNotNull(exception);
		}	
	}
	
	public void testEscapeXMLCDATAWithTwoCDATAClosingTags(){		
		final String stringWithCDATAWithTwoClosingTags = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&lt;![CDATA[&lt;sender&gt;John Inner &amp; CD ]]&gt;&amp; Smith&lt;/sender&gt;]]&gt;bcd &amp; efg&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;		
		final String expectedAfterSecondClosingTagNotEscaped = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&amp;#60;sender&amp;#62;John Inner &amp;#38; CD &amp; Smith&lt;/sender&gt;]]&gt;bcd &amp; efg&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;
		String result = StringFunctions.escapeXML(stringWithCDATAWithTwoClosingTags);
		Assert.assertTrue(result.equals(expectedAfterSecondClosingTagNotEscaped));
	}
	
	public void testEscapeXMLSimpleTwoCDATA(){
		final String stringWithTwoCDATA = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&lt;![CDATA[&lt;sender&gt;John &amp; Smith&lt;/sender&gt;]]&gt;abc&lt;sometag&gt;xyz&lt;/sometag&gt;&lt;sometag2&gt;&lt;![CDATA[&lt;recipient&gt;Gorge &amp; Doe&lt;/recipient&gt;]]&gt;&lt;/sometag2&gt;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;		
		final String expected = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&amp;#60;sender&amp;#62;John &amp;#38; Smith&amp;#60;/sender&amp;#62;abc&lt;sometag&gt;xyz&lt;/sometag&gt;&lt;sometag2&gt;&amp;#60;recipient&amp;#62;Gorge &amp;#38; Doe&amp;#60;/recipient&amp;#62;&lt;/sometag2&gt;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;
		String result = StringFunctions.escapeXML(stringWithTwoCDATA);
		Assert.assertTrue(result.equals(expected));
	}
	
	public void testEscapeXMLOverlappingCDATA(){
		final String stringWithTwoCDATA = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&lt;![CDATA[&lt;sender&gt;John &amp; &lt;![CDATA[Smith&lt;/sender&gt;]]&gt;abc&lt;sometag&gt;xyz&lt;/sometag&gt;&lt;sometag2&gt;&lt;recipient&gt;Gorge &amp; Doe&lt;/recipient&gt;]]&gt;&lt;/sometag2&gt;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;		
		final String expectedMess = &quot;&lt;xml&gt;&lt;SvcRsData&gt;a&amp;#60;sender&amp;#62;John &amp;#38; &amp;#60;![CDATA[Smith&amp;#60;/sender&amp;#62;abc&lt;sometag&gt;xyz&lt;/sometag&gt;&lt;sometag2&gt;&lt;recipient&gt;Gorge &amp; Doe&lt;/recipient&gt;]]&gt;&lt;/sometag2&gt;&lt;/SvcRsData&gt;&lt;/xml&gt; &quot;;
		String result = StringFunctions.escapeXML(stringWithTwoCDATA);
		Assert.assertTrue(result.equals(expectedMess));
	}
	
}

package engine;

public class StringFunctions {
	
	public static String escapeXML(String s) {
		StringBuffer result = new StringBuffer();
		int stringSize = 0;
		int posIniData = 0, posFinData = 0, posIniCData = 0, posFinCData = 0;
		String stringPreData = &quot;&quot;, stringRsData = &quot;&quot;, stringPosData = &quot;&quot;, stringCData = &quot;&quot;, stringPreCData = &quot;&quot;, stringTempRsData = &quot;&quot;;
		String stringNewRsData = &quot;&quot;, stringPosCData = &quot;&quot;, stringNewCData = &quot;&quot;;
		short caracter;
		
		stringSize = s.length();
		posIniData = s.indexOf(&quot;&lt;SvcRsData&gt;&quot;);
		if (posIniData &gt; 0) {
			posIniData = posIniData + 11;
			posFinData = s.indexOf(&quot;&lt;/SvcRsData&gt;&quot;);
			stringPreData = s.substring(0, posIniData);
			stringRsData = s.substring(posIniData, posFinData);
			stringPosData = s.substring(posFinData, stringSize);
			stringTempRsData = stringRsData;
			posIniCData = stringRsData.indexOf(&quot;&lt;![CDATA[&quot;);
			if (posIniCData &gt; 0) {
				while (posIniCData &gt; 0) {
					posIniCData = posIniCData + 9;
					posFinCData = stringTempRsData.indexOf(&quot;]]&gt;&quot;);
					stringPreCData = stringTempRsData.substring(0,
							posIniCData - 9);
					stringCData = stringTempRsData.substring(posIniCData,
							posFinCData);
					stringPosCData = stringTempRsData.substring(
							posFinCData + 3, stringTempRsData.length());

stringNewCData = replaceCharacter(stringCData);
					stringTempRsData = stringTempRsData.substring(
							posFinCData + 3, stringTempRsData.length());
					stringNewRsData = stringNewRsData + stringPreCData
							+ stringNewCData;
					posIniCData = stringTempRsData.indexOf(&quot;&lt;![CDATA[&quot;);
				}
			} else {
				stringNewRsData = stringRsData;
			}
			stringNewRsData = stringNewRsData + stringPosCData;
			s = stringPreData + stringNewRsData + stringPosData;
			stringSize = s.length();
		}

for (int i = 0; i &lt; stringSize; i++) {
			caracter = (short) s.charAt(i);
			if (caracter &gt; 128) {
				result.append(&quot;&amp;#&quot;);
				result.append(caracter);
				result.append(';');
			} else {
				result.append((char) caracter);
			}
		}
		return result.toString();
		
	}

private static String replaceCharacter(String s) {
		StringBuffer result = new StringBuffer();
		int stringSize = s.length();
		short caracter;

for (int i = 0; i &lt; stringSize; i++) {

caracter = (short) s.charAt(i);
			if (caracter &gt; 128 || caracter == 34 || caracter == 38
					|| caracter == 60 || caracter == 62) {
				result.append(&quot;&amp;#&quot;);
				result.append(caracter);
				result.append(';');
			} else {
				result.append((char) caracter);
			}
		}
		return result.toString();

}

}</pre>
<a href="http://www.refactormycode.com/codes/833-refactor-fix-and-optimize-the-character-replacement-function" style="color:#fff" title="As seen on RefactorMyCode.com"><img alt="Small_logo" src="http://www.refactormycode.com/images/small_logo.gif" style="border:0" /></a>

Refactor :my => 'code'

Recent

Popular

Pastable version of Refactor, fix and optimize the character replacement function