Refactor
:my
=>
'code'
Codes
Refactorings
Popular
Best
Submit
Spam
Account
Logout
Login
JavaScript doesn't seem to be activated, expect things to be ugly and sloppy!
Learn How to Create Your Own Programming Language
createyourproglang.com
Recent
How to get accepted in Fileice (200% Working) 22/2012
Premium Account
FILE HOSTS PREMIUM ACCOUNT
ALL FILE HOST PREMIUM ACCOUNTS
Zynga Slingo Trainer v5.12
iTunes Gift Card Generator V3.1 2012
Diablo 3 GOLD Coins FREE
Working PS3 Jailbreak 3.65 And 3.66
ExtaBit Premium Accounts and Cookies
Steam Wallet Hack - Money Adder & Hack v3
Popular
XBOX POINTS GENERATOR - MICROSOFT POINTS GENERATOR v1.2012
11 may 2012 premium uploading accounts 100% working
Free Microsoft Points
Free Microsoft Points - Microsoft Points Generator - Xbox Live Codes 2012
Car Town Free Blue Points Hack
Free CarTown Blue Points Generator and CarTown Templates
Better way to get content via jQuery $.get()
Free Microsoft Points
Simple Days Purger
Sharecash Downloader Bypass Surveys New 05/2012
Pastable version of
Refactoring Help Needed
<pre class='prettyprint' language='cs'>public interface IName { string getLastName(); string getFirstName(); string getMiddleName(); string getSuffixName(); } public class Name : IName { private string _lastName; private string _firstName; private string _middleName; private string _suffixName; // Validation Methods // private set methods #region IName Members public string getLastName() { return _lastName; } public string getFirstName() { return _firstName; } public string getMiddleName() { return _middleName; } public string getSuffixName() { return _suffixName; } #endregion } public interface IAddress { string getAddressNumber(); string getAddressDirection(); string getAddressStreet(); string getAddressStreetType(); string getAddressAptNum(); string getAddressCity(); string getAddressState(); string getAddressZipcode(); string getAddressCounty(); } public class Address : IAddress { private string _addressNumber; private string _addressDirection; private string _addressStreet; private string _addressStreetType; private string _addressAptNum; private string _addressrCity; private string _addressState; private string _addressZipcode; private string _addressCounty; // Validation Methods // private Set Methods // public get methods #region IAddress Members public string getAddressNumber() { return _addressNumber; } public string getAddressDirection() { return _addressDirection; } public string getAddressStreet() { return _addressStreet; } public string getAddressStreetType() { return _addressStreetType; } public string getAddressAptNum() { return _addressAptNum; } public string getAddressCity() { return _addressrCity; } public string getAddressState() { return _addressState; } public string getAddressZipcode() { return _addressZipcode; } public string getAddressCounty() { return _addressCounty; } #endregion } public interface IPerson { int getId(); IName getCurrentName(); IName getFormerName(); IAddress getCurrentAddress(); IAddress getFormerAddress(); IAddress getMailingAddress(); DateTime getBirthdate(); string getGender(); string getSSNumber(); string getPersonType(); DateTime getRegistrationDate(); string getIPAddress(); string getBrowserInfo(); string getHomePhone(); string getWorkPhone(); string getCellPhone(); string getFaxNumber(); string getEmailAddress(); string getSecondaryEmailAddress(); string getDriversLicense(); bool save(); void load(); } public class Person : IPerson { private int _id; private IName _currentName; private IName _formerName; private IAddress _currentAddress; private IAddress _formerAddress; private IAddress _mailingAddress; private DateTime _birthdate; private string _gender; private string _ssNumber; private string _personType; private DateTime _registrationDate; private string _ipAddress; private string _browserInfo; private string _driversLicense; private string _homePhone; private string _workPhone; private string _cellPhone; private string _faxNumber; private string _emailAddress; private string _secondaryEmailAddress; // private set methods #region IPerson Members public bool save() { DataLayer dl = new DataLayer(); if (_id == 0) return dl.insertPerson(this); else return dl.updatePerson(this); } public void load() { } public int getId() { return _id; } public IName getCurrentName() { return _currentName; } public IName getFormerName() { return _formerName; } public IAddress getCurrentAddress() { return _currentAddress; } public IAddress getFormerAddress() { return _formerAddress; } public IAddress getMailingAddress() { return _mailingAddress; } public DateTime getBirthdate() { return _birthdate; } public string getGender() { return _gender; } public string getSSNumber() { return _ssNumber; } public string getPersonType() { return _personType; } public DateTime getRegistrationDate() { return _registrationDate; } public string getIPAddress() { return _ipAddress; } public string getBrowserInfo() { return _browserInfo; } public string getHomePhone() { return _homePhone; } public string getWorkPhone() { return _workPhone; } public string getCellPhone() { return _cellPhone; } public string getFaxNumber() { return _faxNumber; } public string getEmailAddress() { return _emailAddress; } public string getSecondaryEmailAddress() { return _secondaryEmailAddress; } public string getDriversLicense() { return _driversLicense; } #endregion } public class DataLayer { public bool insertPerson(IPerson person) { bool inserted = false; SqlConnection cnDB = DatabaseConnection.GetOpenDBConnection(); try { SqlCommand cmDB = new SqlCommand("sp_InsertName", cnDB); cmDB.CommandType = CommandType.StoredProcedure; cmDB.Parameters.Add("@last_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@last_name"].Value = person.getCurrentName().getLastName(); cmDB.Parameters.Add("@first_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@first_name"].Value = person.getCurrentName().getFirstName(); cmDB.Parameters.Add("@middle_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@middle_name"].Value = person.getCurrentName().getMiddleName(); cmDB.Parameters.Add("@suffix_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@suffix_name"].Value = person.getCurrentName().getSuffixName(); int id = cmDB.ExecuteNonQuery(); cmDB = new SqlCommand("sp_InsertName", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@former_last_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@former_last_name"].Value = person.getFormerName().getLastName(); cmDB.Parameters.Add("@former_first_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@former_first_name"].Value = person.getFormerName().getFirstName(); cmDB.Parameters.Add("@former_middle_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@former_middle_name"].Value = person.getFormerName().getMiddleName(); cmDB.Parameters.Add("@former_suffix_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@former_suffix_name"].Value = person.getFormerName().getSuffixName(); cmDB.ExecuteNonQuery(); // Insert Current Address cmDB = new SqlCommand("sp_InsertAddress", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_number"].Value = person.getCurrentAddress().getAddressNumber(); cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_direction"].Value = person.getCurrentAddress().getAddressDirection(); cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street"].Value = person.getCurrentAddress().getAddressStreet(); cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street_type"].Value = person.getCurrentAddress().getAddressStreetType(); cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_apt_number"].Value = person.getCurrentAddress().getAddressAptNum(); cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_city"].Value = person.getCurrentAddress().getAddressCity(); cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_state"].Value = person.getCurrentAddress().getAddressCity(); cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_zipcode"].Value = person.getCurrentAddress().getAddressZipcode(); cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_county"].Value = person.getCurrentAddress().getAddressCounty(); cmDB.ExecuteNonQuery(); // Insert Former Address cmDB = new SqlCommand("sp_InsertAddress", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_number"].Value = person.getFormerAddress().getAddressNumber(); cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_direction"].Value = person.getFormerAddress().getAddressDirection(); cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street"].Value = person.getFormerAddress().getAddressStreet(); cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street_type"].Value = person.getFormerAddress().getAddressStreetType(); cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_apt_number"].Value = person.getFormerAddress().getAddressAptNum(); cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_city"].Value = person.getFormerAddress().getAddressCity(); cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_state"].Value = person.getFormerAddress().getAddressCity(); cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_zipcode"].Value = person.getFormerAddress().getAddressZipcode(); cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_county"].Value = person.getFormerAddress().getAddressCounty(); cmDB.ExecuteNonQuery(); // Insert Mailing Address cmDB = new SqlCommand("sp_InsertAddress", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_number"].Value = person.getMailingAddress().getAddressNumber(); cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_direction"].Value = person.getMailingAddress().getAddressDirection(); cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street"].Value = person.getMailingAddress().getAddressStreet(); cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street_type"].Value = person.getMailingAddress().getAddressStreetType(); cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_apt_number"].Value = person.getMailingAddress().getAddressAptNum(); cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_city"].Value = person.getMailingAddress().getAddressCity(); cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_state"].Value = person.getMailingAddress().getAddressCity(); cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_zipcode"].Value = person.getMailingAddress().getAddressZipcode(); cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_county"].Value = person.getMailingAddress().getAddressCounty(); cmDB.ExecuteNonQuery(); // insert Personal Info cmDB = new SqlCommand("sp_InsertPersonalInfo", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@birthdate", System.Data.SqlDbType.DateTime); cmDB.Parameters["@birthdate"].Value = person.getBirthdate(); cmDB.Parameters.Add("@gender", System.Data.SqlDbType.VarChar,1); cmDB.Parameters["@gender"].Value = person.getGender(); cmDB.Parameters.Add("@ss_number", System.Data.SqlDbType.VarChar,20); cmDB.Parameters["@ss_number"].Value = person.getSSNumber(); cmDB.Parameters.Add("@person_type", System.Data.SqlDbType.VarChar,20); cmDB.Parameters["@person_type"].Value = person.getPersonType(); cmDB.Parameters.Add("@registration_date", System.Data.SqlDbType.DateTime); cmDB.Parameters["@registration_date"].Value = person.getRegistrationDate(); cmDB.Parameters.Add("@ip_address", System.Data.SqlDbType.VarChar,20); cmDB.Parameters["@ip_address"].Value = person.getIPAddress(); cmDB.Parameters.Add("@browser_info", System.Data.SqlDbType.VarChar,20); cmDB.Parameters["@browser_info"].Value = person.getBrowserInfo(); cmDB.Parameters.Add("@drivers_license", System.Data.SqlDbType.VarChar,20); cmDB.Parameters["@drivers_license"].Value = person.getDriversLicense(); cmDB.ExecuteNonQuery(); //insert email address contact type cmDB = new SqlCommand("sp_InsertContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar,50); cmDB.Parameters["@contact_type"].Value = "Email"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@gender"].Value = person.getEmailAddress(); cmDB.ExecuteNonQuery(); //insert secondary email address contact type cmDB = new SqlCommand("sp_InsertContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Secondary Email"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@gender"].Value = person.getSecondaryEmailAddress(); cmDB.ExecuteNonQuery(); //insert home phone contact type cmDB = new SqlCommand("sp_InsertContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Home Phone"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact"].Value = person.getHomePhone(); cmDB.ExecuteNonQuery(); //insert work phone contact type cmDB = new SqlCommand("sp_InsertContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Work Phone"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact"].Value = person.getWorkPhone(); cmDB.ExecuteNonQuery(); //insert cell phone contact type cmDB = new SqlCommand("sp_InsertContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Cell Phone"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact"].Value = person.getCellPhone(); cmDB.ExecuteNonQuery(); //insert cell phone contact type cmDB = new SqlCommand("sp_InsertContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Fax Number"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact"].Value = person.getFaxNumber(); cmDB.ExecuteNonQuery(); inserted = true; } catch (SqlException sqlEx) { throw new Exception(GetSqlExceptionMessage(sqlEx.Number)); } catch (Exception ex) { throw ex; } finally { if (cnDB.State == ConnectionState.Open) cnDB.Close(); } return inserted; } public bool updatePerson(IPerson person) { bool inserted = false; SqlConnection cnDB = DatabaseConnection.GetOpenDBConnection(); try { string id = person.getId(); SqlCommand cmDB = new SqlCommand("sp_UpdateName", cnDB); cmDB.CommandType = CommandType.StoredProcedure; cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@last_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@last_name"].Value = person.getCurrentName().getLastName(); cmDB.Parameters.Add("@first_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@first_name"].Value = person.getCurrentName().getFirstName(); cmDB.Parameters.Add("@middle_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@middle_name"].Value = person.getCurrentName().getMiddleName(); cmDB.Parameters.Add("@suffix_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@suffix_name"].Value = person.getCurrentName().getSuffixName(); cmDB.ExecuteNonQuery(); cmDB = new SqlCommand("sp_UpdateName", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@former_last_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@former_last_name"].Value = person.getFormerName().getLastName(); cmDB.Parameters.Add("@former_first_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@former_first_name"].Value = person.getFormerName().getFirstName(); cmDB.Parameters.Add("@former_middle_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@former_middle_name"].Value = person.getFormerName().getMiddleName(); cmDB.Parameters.Add("@former_suffix_name", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@former_suffix_name"].Value = person.getFormerName().getSuffixName(); cmDB.ExecuteNonQuery(); // Update Current Address cmDB = new SqlCommand("sp_UpdateAddress", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_number"].Value = person.getCurrentAddress().getAddressNumber(); cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_direction"].Value = person.getCurrentAddress().getAddressDirection(); cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street"].Value = person.getCurrentAddress().getAddressStreet(); cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street_type"].Value = person.getCurrentAddress().getAddressStreetType(); cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_apt_number"].Value = person.getCurrentAddress().getAddressAptNum(); cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_city"].Value = person.getCurrentAddress().getAddressCity(); cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_state"].Value = person.getCurrentAddress().getAddressCity(); cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_zipcode"].Value = person.getCurrentAddress().getAddressZipcode(); cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_county"].Value = person.getCurrentAddress().getAddressCounty(); cmDB.ExecuteNonQuery(); // Update Former Address cmDB = new SqlCommand("sp_UpdateAddress", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_number"].Value = person.getFormerAddress().getAddressNumber(); cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_direction"].Value = person.getFormerAddress().getAddressDirection(); cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street"].Value = person.getFormerAddress().getAddressStreet(); cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street_type"].Value = person.getFormerAddress().getAddressStreetType(); cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_apt_number"].Value = person.getFormerAddress().getAddressAptNum(); cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_city"].Value = person.getFormerAddress().getAddressCity(); cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_state"].Value = person.getFormerAddress().getAddressCity(); cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_zipcode"].Value = person.getFormerAddress().getAddressZipcode(); cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_county"].Value = person.getFormerAddress().getAddressCounty(); cmDB.ExecuteNonQuery(); // Update Mailing Address cmDB = new SqlCommand("sp_UpdateAddress", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@address_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_number"].Value = person.getMailingAddress().getAddressNumber(); cmDB.Parameters.Add("@address_direction", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_direction"].Value = person.getMailingAddress().getAddressDirection(); cmDB.Parameters.Add("@address_street", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street"].Value = person.getMailingAddress().getAddressStreet(); cmDB.Parameters.Add("@address_street_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_street_type"].Value = person.getMailingAddress().getAddressStreetType(); cmDB.Parameters.Add("@address_apt_number", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_apt_number"].Value = person.getMailingAddress().getAddressAptNum(); cmDB.Parameters.Add("@address_city", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_city"].Value = person.getMailingAddress().getAddressCity(); cmDB.Parameters.Add("@address_state", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_state"].Value = person.getMailingAddress().getAddressCity(); cmDB.Parameters.Add("@address_zipcode", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_zipcode"].Value = person.getMailingAddress().getAddressZipcode(); cmDB.Parameters.Add("@address_county", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@address_county"].Value = person.getMailingAddress().getAddressCounty(); cmDB.ExecuteNonQuery(); // Update Personal Info cmDB = new SqlCommand("sp_UpdatePersonalInfo", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@birthdate", System.Data.SqlDbType.DateTime); cmDB.Parameters["@birthdate"].Value = person.getBirthdate(); cmDB.Parameters.Add("@gender", System.Data.SqlDbType.VarChar, 1); cmDB.Parameters["@gender"].Value = person.getGender(); cmDB.Parameters.Add("@ss_number", System.Data.SqlDbType.VarChar, 20); cmDB.Parameters["@ss_number"].Value = person.getSSNumber(); cmDB.Parameters.Add("@person_type", System.Data.SqlDbType.VarChar, 20); cmDB.Parameters["@person_type"].Value = person.getPersonType(); cmDB.Parameters.Add("@registration_date", System.Data.SqlDbType.DateTime); cmDB.Parameters["@registration_date"].Value = person.getRegistrationDate(); cmDB.Parameters.Add("@ip_address", System.Data.SqlDbType.VarChar, 20); cmDB.Parameters["@ip_address"].Value = person.getIPAddress(); cmDB.Parameters.Add("@browser_info", System.Data.SqlDbType.VarChar, 20); cmDB.Parameters["@browser_info"].Value = person.getBrowserInfo(); cmDB.Parameters.Add("@drivers_license", System.Data.SqlDbType.VarChar, 20); cmDB.Parameters["@drivers_license"].Value = person.getDriversLicense(); cmDB.ExecuteNonQuery(); //Update email address contact type cmDB = new SqlCommand("sp_UpdateContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Email"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@gender"].Value = person.getEmailAddress(); cmDB.ExecuteNonQuery(); //Update secondary email address contact type cmDB = new SqlCommand("sp_UpdateContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Secondary Email"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@gender"].Value = person.getSecondaryEmailAddress(); cmDB.ExecuteNonQuery(); //Update home phone contact type cmDB = new SqlCommand("sp_UpdateContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Home Phone"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact"].Value = person.getHomePhone(); cmDB.ExecuteNonQuery(); //Update work phone contact type cmDB = new SqlCommand("sp_UpdateContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Work Phone"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact"].Value = person.getWorkPhone(); cmDB.ExecuteNonQuery(); //Update cell phone contact type cmDB = new SqlCommand("sp_UpdateContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Cell Phone"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact"].Value = person.getCellPhone(); cmDB.ExecuteNonQuery(); //Update cell phone contact type cmDB = new SqlCommand("sp_UpdateContactType", cnDB); cmDB.Parameters.Add("@person_id", System.Data.SqlDbType.Int); cmDB.Parameters["@person_id"].Value = id; cmDB.Parameters.Add("@contact_type", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact_type"].Value = "Fax Number"; cmDB.Parameters.Add("@contact", System.Data.SqlDbType.VarChar, 50); cmDB.Parameters["@contact"].Value = person.getFaxNumber(); cmDB.ExecuteNonQuery(); inserted = true; } catch (SqlException sqlEx) { throw new Exception(GetSqlExceptionMessage(sqlEx.Number)); } catch (Exception ex) { throw ex; } finally { if (cnDB.State == ConnectionState.Open) cnDB.Close(); } return inserted; } }</pre> <a href="http://www.refactormycode.com/codes/798-refactoring-help-needed" style="color:#fff" title="As seen on RefactorMyCode.com"><img alt="Small_logo" src="http://www.refactormycode.com/images/small_logo.gif" style="border:0" /></a>