Pastable version of Separate thread logic from business logic

<pre class='prettyprint' language='java'>public class ServicesRunner {

public static final String SERVICE_ONE = &quot;Service One&quot;;
   public static final String SERVICE_TWO = &quot;Service Two&quot;;
   // ...many other similar strings...
   public static final String SERVICE_N = &quot;Umpteenth service&quot;;

public static final String UNKNOWN_SERVICE = &quot;Unknown Service&quot;;

public String getServiceStatus(String serviceName) {
      if (serviceName.equals(SERVICE_ONE) {
         return getServiceOneStatus;
      } else if (serviceName.equals(SERVICE_TWO) {
         return getServiceTwoStatus;
      }
      // several more else ifs...
      else {
         return UNKNOWN_SERVICE;
      }
   }

private String getServiceOneStatus() {
      if (ServiceOne.getRunner() != null &amp;&amp; ServiceOne.getRunner().isActive()) }
         return RUNNING;
      } else {
         return NOT_RUNNING;
      }
   }

// all other getServiceXStatus are similar (VERY similar... TOO MUCH similar)

public String runService(String ServiceName, MyDataObject myDataObject) {
      if (serviceName.equals(SERVICE_ONE) {
         return runServiceOne(myDataObject);
      } else if ((serviceName.equals(SERVICE_TWO) {
         return runServiceTwo(myDataObject);
      }
      // you guessed right... and so on and so forth
      else {
         return UNKNOWN_SERVICE
      {
   }

private String runServiceOne(MyDataObject data) {
      String result = RUNNING;
      try {
            ServiceOne runner = new ServiceOne();
            runner.setX(data.getX);
            runner.setY(data.getY);
            // etc.
            runner.start();
        } catch (Throwable t) {
            result= t.getMessage();
        }
        return result
   }

// all other run methods are constructed in the same way

}</pre>
<pre class='prettyprint' language='java'>public class ServiceOne {

public static ServiceOne runner = new ServiceOne();
   private boolean active;

private void setActive(boolean active) {
      this.active = active;
   }

public boolean isActive() {
      return active;
   }

public void run() {
      synchronized(serviceOne) { // Synchronization on a non-final field
         if(runner != null &amp;&amp; runner.isActive()) {
            throw new RuntimeException(&quot;service already active&quot;);
         } else {
            runner = this;
            runner.setActive(true);
         }
      }
      try {
         runner.myBusinessStuff();
      } catch(Throwable t) {
         t.printStackTrace();
      } finally {
         runner.setActive(false);
      }
   }

private void myBusinessStuff() {
      // do all that pointless stuff that makes our managers rich
   }

}

public class myServiceX {
   // just like the previous one, with a different runner and different business stuff
   // rinse and repeat for each service
}</pre>
<a href="http://www.refactormycode.com/codes/781-separate-thread-logic-from-business-logic" style="color:#fff" title="As seen on RefactorMyCode.com"><img alt="Small_logo" src="http://www.refactormycode.com/images/small_logo.gif" style="border:0" /></a>

Refactor :my => 'code'

Recent

Popular

Pastable version of Separate thread logic from business logic