035687df00d162cec025302373ebc076

Looking for a better way to define the xml.description node...which needs html embedded as CDATA, but I think it is ugly concating this way with "+".

Generates a description and a link at the bottom.

for directory in @directories
      xml.item do
        xml.title "#{directory.name} (PR #{directory.pagerank})"

        //cleaner proc here?
        xml.description { xml.cdata! simple_format(directory.description) + simple_format(link_to directory.software.name, software_url(directory.software)) }

        xml.pubDate directory.created_at.to_s(:rfc822)
        xml.link directory_url(directory)
        xml.guid directory_url(directory)
      end
    end

Refactorings

No refactoring yet !

22e33503870d8e20493c4dd6b2f9767f

rikkus

November 5, 2008, November 05, 2008 12:47, permalink

No rating. Login to rate!

It looks like you're concatenating plain text and HTML. Perhaps you should make your description HTML and embed the link inside it using standard XML tools?

A8d3f35baafdaea851914b17dae9e1fc

Adam

November 5, 2008, November 05, 2008 16:12, permalink

No rating. Login to rate! 
for directory in @directories
  xml.item do
    xml.title "#{directory.name} (PR #{directory.pagerank})"

    //cleaner proc here?
    xml.description do
      xml.cdata! h(render(:partial => directory))
    end

    xml.pubDate directory.created_at.to_s(:rfc822)
    xml.link directory_url(directory)
    xml.guid directory_url(directory)
  end
end
<%= simple_format directory.description %>
<p><%= link_to directory.software.name, software_url(directory.software) %></p>

Your refactoring





Format Copy from initial code

or Cancel