Pastable version of DRYing/shortening form processing

<pre class='prettyprint' language='ruby'>def self.filter_price(direction, price)
    return nil if direction.blank? or price.blank?
    return {:error =&gt; 'Invalid argument: direction'} unless ['at most', 'at least'].include? direction
    return {:error =&gt; 'Invalid argument: price'}     unless price.to_s =~ /\A[0-9]+\Z/

case direction
      when 'at most'  then  return  {:sql =&gt; 'price &lt;= :price', :price  =&gt; price.to_s}
      when 'at least' then  return  {:sql =&gt; 'price &gt;= :price', :price  =&gt; price.to_s}
      else                  raise   'Unknown error'
    end
  end

def self.filter_bedrooms(bedrooms)
    return nil if bedrooms.blank?
    return {:error =&gt; 'Invalid argument: bedrooms'} unless bedrooms.to_s =~ /\A[0-9]+\Z/

{:sql =&gt; 'bedrooms = :bedrooms', :bedrooms =&gt; bedrooms.to_s}
  end

#
  # ...Snip. There are several more methods like the ones above...
  #

def self.filtered_properties(params)
    conditions_string = ''
    conditions_hash   = {}      # Stores the conditions for filtering out properties.
    condition_errors  = []      # Stores errors related to a filter request.

# Process the &quot;price&quot; and &quot;price_direction&quot; params.
    filtered = filter_price params[:price_direction], params[:price]
    if filtered.blank?      # Do nothing.
    elsif filtered[:error]
      condition_errors &lt;&lt; 'Please provide a number for the price. Eg: 1500'
    else
      conditions_string &lt;&lt; filtered[:sql]
      conditions_hash[:price] = filtered[:price]
    end

# Process the &quot;bedrooms&quot; param.
    filtered = filter_bedrooms params[:bedrooms]
    if filtered.blank?      # Do nothing.
    elsif filtered[:error]
      condition_errors &lt;&lt; 'Please provide a number for the bedrooms. Eg: 2'
    else
      conditions_string &lt;&lt; ' AND ' &lt;&lt; filtered[:sql]
      conditions_hash[:bedrooms] = filtered[:bedrooms]
    end

# Process the &quot;bathrooms&quot; param.
    filtered = filter_bathrooms params[:bathrooms]
    if filtered.blank?      # Do nothing.
      puts '&gt; bathrooms is blank'
    elsif filtered[:error]
      condition_errors &lt;&lt; 'Please provide a number for the bathrooms. Eg: 2'
    else
      conditions_string &lt;&lt; ' AND ' &lt;&lt; filtered[:sql]
      conditions_hash[:bathrooms] = filtered[:bathrooms]
    end

# ...snip...

return condition_errors unless condition_errors.empty?

self.find :all, :conditions =&gt; [conditions_string, conditions_hash]

end # End #filtered_properties</pre>
<a href="http://www.refactormycode.com/codes/558-drying-shortening-form-processing" style="color:#fff" title="As seen on RefactorMyCode.com"><img alt="Small_logo" src="http://www.refactormycode.com/images/small_logo.gif" style="border:0" /></a>

Refactor :my => 'code'

Recent

Popular

Pastable version of DRYing/shortening form processing