51224bdd17878b3b19e8987e9bb336a2

Hi,
- In following code snippet maximum code is getting repeat only image name & action name are changing as per the value of @favorite_flag.

Thanks
DG

<% if @favorite_flag %>

<div class="float-l-r" > 

<%=link_to_remote image_tag('blue-star-howto.jpg'),
   :update => "rating",
   :url => { :controller => "howto", :action => "delete_favorite",:id => @howtoguide.id }%> 

</div>

<% else %>

<div class="float-l-r" > 

<%= link_to_remote image_tag('blank_star_image.jpg'),
   :update => "rating",
   :url => { :controller => "howto", :action => "update_favorite",:id => @howtoguide.id }%> 
</div>

<% end%>

Refactorings

No refactoring yet !

Ee8ea294c76022c5a6e163a05d255700

Apirak Panatkool

August 21, 2008, August 21, 2008 15:08, permalink

1 rating. Login to rate!
<% 
@link =  @favorite_flag ? ["blue-star-howto.jpg", "delete_favorite"] : [ "blank_star_image.jpg", "update_favorite"]
%>

<div class="float-l-r" >
<%=link_to_remote image_tag(@link[0]),
   :update => "rating",
   :url => { :controller => "howto", :action => @link[1], :id => @howtoguide.id }%> 
</div>
Ee8ea294c76022c5a6e163a05d255700

Apirak Panatkool

August 21, 2008, August 21, 2008 15:13, permalink

1 rating. Login to rate!

do it simple way

<% 
if @favorite_flag 
  @image =  "blue-star-howto.jpg"
  @action = "delete_favorite"
else
  @image =  "blank_star_image.jpg"
  @action = "update_favorite"
end
%>

<div class="float-l-r" > 

<%=link_to_remote image_tag(@image),
   :update => "rating",
   :url => { :controller => "howto", :action => @action, :id => @howtoguide.id }%> 

</div>
739c2c53620415629cca9fefecd37780

Juan Ayup

February 17, 2009, February 17, 2009 21:00, permalink

No rating. Login to rate!

HTH

<% 
@image,@action =  @favorite_flag ? ["blue-star-howto.jpg", "delete_favorite"] : [ "blank_star_image.jpg", "update_favorite"]
%>

<div class="float-l-r" >
<%=link_to_remote image_tag(@image),
   :update => "rating",
   :url => { :controller => "howto", :action => @action, :id => @howtoguide.id }%> 
</div>

Your refactoring





Format Copy from initial code

or Cancel