55502f40dc8b7c769880b10874abc9d0

Function to fetch and parse feeds with feedzirra and make it ready for view

def load_feeds 
  #feed url
  po = 'http://feed.kennisnet.nl/Basisonderwijs'
  vo = 'http://feed.kennisnet.nl/Voortgezetonderwijs'
  ds = 'http://wp.digischool.nl/nieuws/feed/'
  #Define feed urls
  @feed_urls = [ds, po, vo]
  #fetch feeds
  @feeds = Feedzirra::Feed.fetch_and_parse(@feed_urls)
  #trim feeds to 6 feeds    
  short_list = @feeds.values.map{|f| f.entries[0,5]}
  @feeds_ds = short_list.entries.first
  if params[:vopo] == "po"
    @feeds = short_list.entries.second
  else
    @feeds = short_list.entries.last
  end
end

Refactorings

No refactoring yet !

A8d3f35baafdaea851914b17dae9e1fc

Adam

August 24, 2010, August 24, 2010 00:41, permalink

1 rating. Login to rate! 
class Feeds
  FEEDS = %W(
    http://feed.kennisnet.nl/Basisonderwijs
    http://feed.kennisnet.nl/Voortgezetonderwijs
    http://wp.digischool.nl/nieuws/feed/
  )

  def load_feeds
    @feeds_ds = feeds.first
    @feeds = vopo? ? feeds.second : feeds.last
  end

  def feeds
    @feeds ||= Feedzirra::Feed.fetch_and_parse(FEEDS).values.map { |feed| feed.entries.first(6) }.entries
  end  
  
  def vopo?
    params[:vopo] == 'po'
  end
end
9dc2fe52cbc7a4f42b54d056e470efea

Krzysztof Wilczynski

August 24, 2010, August 24, 2010 12:42, permalink

No rating. Login to rate!

Adam += 1, nice re-factoring.

Your refactoring





Format Copy from initial code

or Cancel