55502f40dc8b7c769880b10874abc9d0

any optimisations on this little rack module?

module Rack
  class SslBlock
    def initialize app, options = {}
      @app, @options = app, options
    end

    def call env
      if ssl_blocked_request? env, @options
        [403, {'Content-Type' => 'text/plain'}, "Forbidden"]
      else
        @app.call env
      end
    end

    private
      def ssl_blocked_request? env, options
        if env['HTTP_USER_AGENT'] && env['rack.url_scheme'] == 'https' && options.has_key?(:user_agents)
          options[:user_agents].each { |user_agent| return true if env['HTTP_USER_AGENT'].downcase.include? user_agent.downcase }
          false
        end
      end
  end
end

Refactorings

No refactoring yet !

55502f40dc8b7c769880b10874abc9d0

https://www.google.com/accounts/o8/id?id=AItOawkgnP7evEXOMIOnxq71Y4yEhDFN2oe3qi4

July 26, 2010, July 26, 2010 14:45, permalink

No rating. Login to rate!

maybe this would be better? thoughts? 

options[:user_agents].any? { |user_agent| env['HTTP_USER_AGENT'].downcase.include? user_agent.downcase }
55502f40dc8b7c769880b10874abc9d0

https://www.google.com/accounts/o8/id?id=AItOawkgnP7evEXOMIOnxq71Y4yEhDFN2oe3qi4

July 27, 2010, July 27, 2010 12:54, permalink

No rating. Login to rate!

better still?

options[:user_agents].any? { |user_agent| env['HTTP_USER_AGENT'] =~ /#{user_agent}/i }

Your refactoring





Format Copy from initial code

or Cancel